Skip to content

Commit 20d5d2f

Browse files
committed
Fix typo and add test for error message
1 parent 03c3129 commit 20d5d2f

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/Response.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function __construct($text, &$client = null)
6262

6363
$e = $doc->first('/srw:searchRetrieveResponse/srw:diagnostics');
6464
if ($e) {
65-
$this->error = $e->text('d:diagnostic/d:messsage') . ' : ' . $e->text('d:diagnostic/d:details');
65+
$this->error = $e->text('d:diagnostic/d:message') . '. ' . $e->text('d:diagnostic/d:details');
6666
}
6767

6868
$this->client = $client;

tests/ResponseTest.php

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,21 @@ public function testMultipleRecordsResult()
9696
$this->assertEquals('Record 1', $res->records[0]->data);
9797
}
9898

99+
public function testError()
100+
{
101+
$res = new Response('<srw:searchRetrieveResponse xmlns:srw="http://www.loc.gov/zing/srw/">
102+
<srw:version>1.1</srw:version>
103+
<srw:numberOfRecords>0</srw:numberOfRecords>
104+
<srw:diagnostics xmlns="http://www.loc.gov/zing/srw/diagnostic/">
105+
<diagnostic >
106+
<uri>info:srw/diagnostic/1/66</uri>
107+
<details>Invalid parameter: \'marcxml\' for service: \'biblio\'</details>
108+
<message>Unknown schema for retrieval</message>
109+
</diagnostic>
110+
</srw:diagnostics>
111+
</srw:searchRetrieveResponse>');
112+
113+
$this->assertEquals('Unknown schema for retrieval. Invalid parameter: \'marcxml\' for service: \'biblio\'', $res->error);
114+
}
115+
99116
}

0 commit comments

Comments
 (0)