Add tests

Author: danmichaelo

src/Client.php

@@ -145,11 +145,12 @@ public function search($cql, $start = 1, $count = 10) {
      *
      * @param string $cql
      * @param int $count Number of records to request per request
+     * @param mixed $httpClient A http client
      * @return Records
      */
-    public function records($cql, $count = 10)
+    public function records($cql, $count = 10, $httpClient = null)
     {
-        return new Records($cql, $this, $count);
+        return new Records($cql, $this, $count, $httpClient);
     }
 
     /**

src/ExplainResponse.php

@@ -29,7 +29,11 @@ public function __construct($text, &$client = null)
     {
         parent::__construct($text, $client);
 
+        $this->indexes = array();
+
         $explain = $this->response->first('/srw:explainResponse/srw:record/sru:recordData/exp:explain');
+        if (!$explain) return;
+
         $serverInfo = $explain->first('exp:serverInfo');
         $dbInfo = $explain->first('exp:databaseInfo');
         $indexInfo = $explain->first('exp:indexInfo');
@@ -41,7 +45,6 @@ public function __construct($text, &$client = null)
         $this->database->title = $dbInfo->text('exp:title');
         $this->database->description = $dbInfo->text('exp:description');
 
-        $this->indexes = array();
         foreach ($indexInfo->xpath('exp:index') as $index) {
             $ind = new \StdClass;
             $ind->scan = ($index->attr('scan') == 'true');

tests/ClientTest.php

@@ -11,6 +11,10 @@ class ClientTest extends TestCase {
               <srw:searchRetrieveResponse xmlns:srw="http://www.loc.gov/zing/srw/" xmlns:xcql="http://www.loc.gov/zing/cql/xcql/">
               </srw:searchRetrieveResponse>';
 
+    protected $simple_explain_response = '<?xml version="1.0" encoding="UTF-8"?>
+            <sru:explainResponse xmlns:sru="http://www.loc.gov/zing/srw/">
+            </sru:explainResponse>';
+
     public function testUrlTo()
     {
         $sru1 = new Client($this->url);
@@ -156,5 +160,45 @@ public function testNext()
 
     }
 
+    public function testHttpOptions()
+    {
+        $sru1 = new Client($this->url, array(
+            'user-agent' => 'Blablabla/0.1',
+            'credentials' => array('myuser', 'mypass'),
+            'proxy' => 'proxyhost:80'
+        ));
+
+        $opts = $sru1->getHttpOptions();
+
+        $this->assertEquals('application/xml', $opts['headers']['Accept']);
+        $this->assertEquals('Blablabla/0.1', $opts['headers']['User-Agent']);
+        $this->assertEquals(array('myuser', 'mypass'), $opts['auth']);
+        $this->assertEquals('proxyhost:80', $opts['proxy']);
+    }
+
+    public function testRecords()
+    {
+        $http = $this->httpMockSingleResponse($this->makeDummyResponse(1));
+
+        $sru1 = new Client($this->url);
+        $r = $sru1->records('test', 1, $http);
+
+        $this->assertInstanceOf('Scriptotek\Sru\Records', $r);
+    }
+
+    public function testExplain()
+    {
+        $http = $this->httpMockSingleResponse($this->simple_explain_response);
+        $sru = new Client($this->url, null, $http);
+        $exp = $sru->explain();
+
+        $this->assertInstanceOf('Scriptotek\Sru\ExplainResponse', $exp);
+
+        $this->assertXmlStringEqualsXmlString(
+            $this->simple_explain_response,
+            $exp->asXml()
+        );
+    }
+
 }