Skip to content

Commit a2cd23f

Browse files
hemnstillstipsan
authored andcommitted
An argument finalElement was added to limit the scope of the function. (#108)
1 parent bd07874 commit a2cd23f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import animate from 'amator'
22

3-
export default function (elem, centerIfNeeded, options) {
3+
export default function (elem, centerIfNeeded, options, finalElement) {
44

55
if (!elem) throw new Error('Element is required in scrollIntoViewIfNeeded')
66

@@ -43,7 +43,7 @@ export default function (elem, centerIfNeeded, options) {
4343
var parent, area = makeArea(
4444
elem.offsetLeft, elem.offsetTop,
4545
elem.offsetWidth, elem.offsetHeight);
46-
while ((parent = elem.parentNode) instanceof HTMLElement) {
46+
while ((parent = elem.parentNode) instanceof HTMLElement && elem !== finalElement) {
4747
var clientLeft = parent.offsetLeft + parent.clientLeft;
4848
var clientTop = parent.offsetTop + parent.clientTop;
4949

typings.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,5 @@ export default function(
88
node: Element,
99
centerIfNeeded: boolean,
1010
options?: ScrollIntoViewIfNeededOptions,
11+
finalElement?: Element
1112
): void;

0 commit comments

Comments
 (0)