Use NativeSumcheck for calculating initial_sum (#1249)

Optimization for Calculating Initial Sum in tower verify.
- Remove dot product logic for calculating `initial_sum`. Use
`NativeSumcheck` instead.
- Flatten out evaluation arrays.
- Remove arithmetic utilities no longer required.

Optimization for `NativeSumcheck`
- Use the additional mode on `NativeSumcheck` chip that allows passing
in hint space IDs for evaluation inputs instead of loading concrete
witness arrays. This significantly reduces cycles involved in loading
witnesses.

---------

Co-authored-by: kunxian xia <xiakunxian130@gmail.com>

Author: darth-cy

.gitignore

@@ -15,3 +15,4 @@ docs/book
 # ceno serialized files
 *.bin
 *.json
+*.srs

Cargo.lock

@@ -92,16 +92,16 @@ ceno_gpu = { git = "https://github.com/scroll-tech/ceno-gpu-mock.git", package =
 cudarc = { version = "0.17.3", features = ["driver", "cuda-version-from-build-system"] }
 
 # ceno-recursion dependencies
-openvm = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-continuations = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-instructions = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-native-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-native-compiler = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-native-compiler-derive = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-native-recursion = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-rv32im-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
-openvm-sdk = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/v1.4.1-scroll-ext", default-features = false }
+openvm = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-continuations = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-instructions = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-native-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-native-compiler = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-native-compiler-derive = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-native-recursion = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-rv32im-circuit = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
+openvm-sdk = { git = "https://github.com/scroll-tech/openvm.git", branch = "feat/native_sc_writeback", default-features = false }
 
 openvm-cuda-backend = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.2.1", default-features = false }
 openvm-stark-backend = { git = "https://github.com/openvm-org/stark-backend.git", tag = "v1.2.1", default-features = false }

Cargo.toml

@@ -693,6 +693,7 @@ pub fn verify_proofs(
 
         let fri_params = standard_fri_params_with_100_bits_conjectured_security(1);
         let vb = NativeBuilder::default();
+
         air_test_impl::<BabyBearPoseidon2Engine, _>(
             fri_params,
             vb,
@@ -703,6 +704,13 @@ pub fn verify_proofs(
             true,
         )
         .unwrap();
+
+        // _debug
+        // let engine = BabyBearPoseidon2Engine::new(fri_params);
+        // let (mut vm, pk) = VirtualMachine::new_with_keygen(engine, vb, config).expect("create vm");
+        // let vk = pk.get_vk();
+        // vm.verify(&vk, &proofs)
+        //     .expect("segment proofs should verify");
     }
 }
 

ceno_recursion/src/aggregation/mod.rs

@@ -98,18 +98,6 @@ pub fn is_smaller_than<C: Config>(
     RVar::from(v)
 }
 
-pub fn evaluate_at_point_degree_1<C: Config>(
-    builder: &mut Builder<C>,
-    evals: &Array<C, Ext<C::F, C::EF>>,
-    point: &Array<C, Ext<C::F, C::EF>>,
-) -> Ext<C::F, C::EF> {
-    let left = builder.get(evals, 0);
-    let right = builder.get(evals, 1);
-    let r = builder.get(point, 0);
-
-    builder.eval(r * (right - left) + left)
-}
-
 pub fn _fixed_dot_product<C: Config>(
     builder: &mut Builder<C>,
     a: &[Ext<C::F, C::EF>],
@@ -329,24 +317,6 @@ pub fn eq_eval_with_index<C: Config>(
     acc
 }
 
-// Multiply all elements in a nested Array
-pub fn nested_product<C: Config>(
-    builder: &mut Builder<C>,
-    arr: &Array<C, Array<C, Ext<C::F, C::EF>>>,
-) -> Ext<C::F, C::EF> {
-    let acc = builder.constant(C::EF::ONE);
-    iter_zip!(builder, arr).for_each(|ptr_vec, builder| {
-        let inner_arr = builder.iter_ptr_get(arr, ptr_vec[0]);
-
-        iter_zip!(builder, inner_arr).for_each(|ptr_vec, builder| {
-            let el = builder.iter_ptr_get(&inner_arr, ptr_vec[0]);
-            builder.assign(&acc, acc * el);
-        });
-    });
-
-    acc
-}
-
 // Multiply all elements in an Array
 pub fn arr_product<C: Config>(
     builder: &mut Builder<C>,