Skip to content

Commit 4f13363

Browse files
Apply suggestions from code review
Co-authored-by: colin <[email protected]>
1 parent 8fa5e27 commit 4f13363

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

encoding/codecv7.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ func (d *DACodecV7) constructBlobPayload(batch *Batch) ([]byte, error) {
222222
}
223223

224224
// NewDABatchFromBytes decodes the given byte slice into a DABatch.
225-
// Note: This function only populates the batch header, it leaves the blob-related fields and skipped L1 message bitmap empty.
225+
// Note: This function only populates the batch header, it leaves the blob-related fields empty.
226226
func (d *DACodecV7) NewDABatchFromBytes(data []byte) (DABatch, error) {
227227
daBatch, err := decodeDABatchV7(data)
228228
if err != nil {

encoding/codecv7_types.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ const (
2828
)
2929

3030
// Below is the encoding format for BlobEnvelopeV7.
31-
// * Field Bytes Type Index Comments
32-
// * version 1 uint8 0 The version of the DA codec (batch/blob)
33-
// * n_bytes[1] 1 uint8 1 Value denoting the number of bytes, n_bytes[1]*256^2
34-
// * n_bytes[2] 1 uint8 2 Value denoting the number of bytes, n_bytes[2]*256
35-
// * n_bytes[3] 1 uint8 3 Value denoting the number of bytes, n_bytes[3]
36-
// * flag 1 bool 4 1-byte flag to denote zstd-encoded/raw bytes
37-
// * payload N bytes 5 Possibly zstd-encoded payload bytes
38-
// * padding (4096*31 - (N+5)) bytes N+5 Padding to align to 4096*31 bytes
31+
// * Field Bytes Type Index Comments
32+
// * version 1 uint8 0 The version of the DA codec (batch/blob)
33+
// * n_bytes[1] 1 uint8 1 Value denoting the number of bytes, n_bytes[1]*256^2
34+
// * n_bytes[2] 1 uint8 2 Value denoting the number of bytes, n_bytes[2]*256
35+
// * n_bytes[3] 1 uint8 3 Value denoting the number of bytes, n_bytes[3]
36+
// * flag 1 bool 4 1-byte flag to denote zstd-encoded/raw bytes
37+
// * payload N bytes 5 Possibly zstd-encoded payload bytes
38+
// * padding (4096*31 - (N+5)) bytes N+5 Padding to align to 4096*31 bytes
3939

4040
const (
4141
blobEnvelopeV7OffsetVersion = 0
@@ -45,7 +45,7 @@ const (
4545
)
4646

4747
// Below is the encoding for blobPayloadV7.
48-
// * Field Bytes Type Index Comments
48+
// * Field Bytes Type Index Comments
4949
// * initialL1MessageIndex 8 uint64 0 Queue index of the first L1 message contained in this batch
5050
// * initialL1MessageQueueHash 32 bytes32 8 Hash of the L1 message queue at the last message in the previous batch
5151
// * lastL1MessageQueueHash 32 bytes32 40 Hash of the L1 message queue at the last message in this batch

0 commit comments

Comments
 (0)