address review comments

Author: jonastheis

encoding/codecv7_test.go

@@ -409,9 +409,9 @@ func TestCodecV7BatchStandardTestCasesEnableCompression(t *testing.T) {
 		expectedBlobVersionedHash string
 	}{
 		{
-			name:                      "no blocks",
-			txData:                    []string{},
-			expectedBlobVersionedHash: "0x018ea63fc2caaef749cedbeb0d890c006692a5507bb184817483bd5067e432b9",
+			name:        "no blocks",
+			txData:      []string{},
+			creationErr: "no blocks",
 		},
 		{
 			name:                      "single block, single tx",
@@ -553,9 +553,9 @@ func TestCodecV7BatchStandardTestCasesDisableCompression(t *testing.T) {
 		expectedBlobVersionedHash string
 	}{
 		{
-			name:                      "no blocks",
-			txData:                    []string{},
-			expectedBlobVersionedHash: "0x0127467f5062c887d10c72713d76406ef5caebe2df5b1b679a1b5cd812cf395b",
+			name:        "no blocks",
+			txData:      []string{},
+			creationErr: "no blocks",
 		},
 		{
 			name:                      "single block, single tx",

encoding/codecv7_types.go

@@ -53,9 +53,9 @@ const (
 //   * postL1MessageQueueHash      32        bytes32        32          hash of the L1 message queue at the end of this batch
 //   * initialL2BlockNumber        8         uint64         64          The initial L2 block number in this batch
 //   * numBlocks                   2         uint16         72          The number of blocks in this batch
-//   * block[0]                    52        DABlock7   	74          The first block in this batch
-//   * block[i]                    52        DABlock7   	74+52*i     The (i+1)th block in this batch
-//   * block[n-1]                  52        DABlock7   	74+52*(n-1) The last block in this batch
+//   * block[0]                    52        DABlock7       74          The first block in this batch
+//   * block[i]                    52        DABlock7       74+52*i     The (i+1)th block in this batch
+//   * block[n-1]                  52        DABlock7       74+52*(n-1) The last block in this batch
 //   * l2Transactions              dynamic   bytes          74+52*n     L2 transactions for this batch
 
 const (
@@ -517,7 +517,7 @@ func encodeSize3Bytes(data uint32) []byte {
 // The function calls the blockCallBack for each block with the block and the corresponding daBlock.
 func iterateAndVerifyBlocksAndL1Messages(prevL1MessageQueueHash, postL1MessageQueueHash common.Hash, blocks []*Block, totalL1MessagePoppedBefore *uint64, initialL2BlockNumberCallback func(initialL2BlockNumber uint64), blockCallBack func(block *Block, daBlock *daBlockV7) error) error {
 	if len(blocks) == 0 {
-		return nil
+		return errors.New("no blocks to iterate")
 	}
 
 	if !blocks[0].Header.Number.IsUint64() {