wip3

Author: kunxian-xia

extensions/native/circuit/src/extension/mod.rs

@@ -179,7 +179,7 @@ impl<F: PrimeField32> VmExecutionExtension<F> for Native {
         inventory.add_executor(
             tower_verify,
             [SumcheckOpcode::SUMCHECK_LAYER_EVAL.global_opcode()],
-        );
+        )?;
 
         inventory.add_phantom_sub_executor(
             NativeHintInputSubEx,

extensions/native/circuit/src/sumcheck/execution.rs

@@ -215,7 +215,7 @@ unsafe fn execute_e12_impl<F: PrimeField32, CTX: ExecutionCtxTrait>(
     let c1: [F; EXT_DEG] = challenges[EXT_DEG..EXT_DEG * 2].try_into().unwrap();
     let c2: [F; EXT_DEG] = challenges[EXT_DEG * 2..EXT_DEG * 3].try_into().unwrap();
 
-    let mut height = 0;
+    let mut height = 1;
     let mut alpha_acc = elem_to_ext(F::ONE);
     let mut eval_acc = elem_to_ext(F::ZERO);
 
@@ -265,8 +265,8 @@ unsafe fn execute_e12_impl<F: PrimeField32, CTX: ExecutionCtxTrait>(
             .vm_read(NATIVE_AS, ctx_ptr_u32 + 8 + num_prod_spec + i)
             .map(|x: F| x.as_canonical_u32());
         let start = calculate_3d_ext_idx(
-            prod_specs_inner_inner_len,
-            prod_specs_inner_len,
+            logup_specs_inner_len,
+            logup_specs_inner_inner_len,
             i,
             round,
             0,
@@ -330,6 +330,9 @@ unsafe fn execute_e12_impl<F: PrimeField32, CTX: ExecutionCtxTrait>(
         height += 1;
     }
 
+    *pc += DEFAULT_PC_STEP;
+    *instret += 1;
+
     exec_state.vm_write(NATIVE_AS, r_evals_ptr_u32, &eval_acc);
     // return height delta
     height

extensions/native/recursion/tests/sumcheck.rs

@@ -30,7 +30,6 @@ use openvm_stark_sdk::{
     },
     engine::StarkFriEngine,
     p3_baby_bear::BabyBear,
-    utils::{create_seeded_rng, ProofInputForTest},
 };
 
 pub type F = BabyBear;
@@ -42,15 +41,11 @@ fn test_sumcheck_layer_eval() {
 
     build_test_program(&mut builder);
 
-    // Fill in test program logic
-    builder.halt();
-
     let compilation_options = CompilerOptions::default().with_cycle_tracker();
     let mut compiler = AsmCompiler::new(compilation_options.word_size);
     compiler.build(builder.operations);
     let asm_code = compiler.code();
 
-    // let program = Program::from_instructions(&instructions);
     let program: Program<_> = convert_program(asm_code, compilation_options);
     let sumcheck_max_constraint_degree = 3;
     let fri_params = if matches!(std::env::var("OPENVM_FAST_TEST"), Ok(x) if &x == "1") {
@@ -1268,4 +1263,6 @@ fn build_test_program<C: Config>(builder: &mut Builder<C>) {
         &logup_spec_evals,
         &next_layer_evals,
     );
+
+    builder.halt();
 }