wip14

Author: kunxian-xia

extensions/native/circuit/src/sumcheck/air.rs

@@ -366,12 +366,15 @@ impl<AB: InteractionBuilder> Air<AB> for NativeSumcheckAir {
             )
             .eval(builder, prod_row);
 
-        // TODO: reduce the degree
-        // builder.when(prod_row * within_round_limit).assert_eq(
-        //     prod_row_specific.data_ptr,
-        //     (prod_nested_len * (curr_prod_n - AB::F::ONE) + prod_spec_inner_inner_len * round)
-        //         * AB::F::from_canonical_usize(EXT_DEG),
-        // );
+        // prod_row * within_round_limit =
+        //    prod_in_round_evaluation + prod_next_round_evaluation
+        builder
+            .when(prod_in_round_evaluation + prod_next_round_evaluation)
+            .assert_eq(
+                prod_row_specific.data_ptr,
+                (prod_nested_len * (curr_prod_n - AB::F::ONE) + prod_spec_inner_inner_len * round)
+                    * AB::F::from_canonical_usize(EXT_DEG),
+            );
         builder.assert_eq(
             prod_row * within_round_limit * in_round,
             prod_in_round_evaluation,
@@ -466,12 +469,16 @@ impl<AB: InteractionBuilder> Air<AB> for NativeSumcheckAir {
             )
             .eval(builder, logup_row);
 
-        // TODO: reduce the degree
-        // builder.when(logup_row * within_round_limit).assert_eq(
-        //     logup_row_specific.data_ptr,
-        //     (logup_nested_len * (curr_logup_n - AB::F::ONE) + logup_spec_inner_inner_len * round)
-        //         * AB::F::from_canonical_usize(EXT_DEG),
-        // );
+        // logup_row * within_round_limit =
+        //    logup_in_round_evaluation + logup_next_round_evaluation
+        builder
+            .when(logup_in_round_evaluation + logup_next_round_evaluation)
+            .assert_eq(
+                logup_row_specific.data_ptr,
+                (logup_nested_len * (curr_logup_n - AB::F::ONE)
+                    + logup_spec_inner_inner_len * round)
+                    * AB::F::from_canonical_usize(EXT_DEG),
+            );
         builder.assert_eq(
             logup_row * within_round_limit * in_round,
             logup_in_round_evaluation,

extensions/native/circuit/src/sumcheck/chip.rs

@@ -357,8 +357,8 @@ where
             if round < max_round - 1 {
                 logup_row.within_round_limit = F::ONE;
                 let start = calculate_3d_ext_idx(
-                    prod_specs_inner_inner_len,
-                    prod_specs_inner_len,
+                    logup_specs_inner_inner_len,
+                    logup_specs_inner_len,
                     i as u32,
                     round,
                     0,

extensions/native/compiler/src/ir/sumcheck.rs

@@ -1,8 +1,4 @@
-use openvm_native_compiler_derive::iter_zip;
-use openvm_stark_backend::p3_field::FieldAlgebra;
-
-use super::{Array, ArrayLike, Builder, Config, DslIr, Ext, Felt, MemIndex, Ptr, Usize, Var};
-use crate::ir::Variable;
+use super::{Array, Builder, Config, DslIr, Ext, Usize};
 
 impl<C: Config> Builder<C> {
     /// Extends native VM ability to calculate the evaluation for a sumcheck layer