Native Sumcheck Layer Evaluation (#8)

* Add native sumcheck chip

* Complete sumcheck layer execution logic

* Remove debug flags

* Add variation

* Cherry pick column reduction commits

* Add record assignments

* Adjust unit test

* Correct header row register reads

* Correct header row register reads

* Correct header row register read

* Correct rw records for prod rows

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Degree reduction

* Reduce degree

* Reduce degree

* Disable debug flag

* Debug constraints

* Recover constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints:

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Debug constraints

* Add debug flag

* Remove debug flags

* Debug constraint

* Correct constraints

* Remove debug flags

* Prover field access

* Remove debug flag

* Add documentation

* Adjust documentation

* Add documentation

---------

Co-authored-by: Ray Gao <[email protected]>

Author: darth-cy

.gitignore

@@ -9,6 +9,9 @@ Cargo.lock
 **/.env
 .DS_Store
 
+# Log outputs
+*.log
+
 .cache/
 rustc-*
 

crates/sdk/src/prover/agg.rs

@@ -23,11 +23,11 @@ use crate::{
 };
 
 pub struct AggStarkProver<E: StarkFriEngine<SC>> {
-    leaf_prover: VmLocalProver<SC, NativeConfig, E>,
-    leaf_controller: LeafProvingController,
+    pub leaf_prover: VmLocalProver<SC, NativeConfig, E>,
+    pub leaf_controller: LeafProvingController,
 
-    internal_prover: VmLocalProver<SC, NativeConfig, E>,
-    root_prover: RootVerifierLocalProver,
+    pub internal_prover: VmLocalProver<SC, NativeConfig, E>,
+    pub root_prover: RootVerifierLocalProver,
 
     pub num_children_internal: usize,
     pub max_internal_wrapper_layers: usize,

extensions/native/circuit/src/extension.rs

@@ -15,9 +15,7 @@ use openvm_circuit_derive::{AnyEnum, InstructionExecutor, VmConfig};
 use openvm_circuit_primitives_derive::{Chip, ChipUsageGetter};
 use openvm_instructions::{program::DEFAULT_PC_STEP, LocalOpcode, PhantomDiscriminant};
 use openvm_native_compiler::{
-    CastfOpcode, FieldArithmeticOpcode, FieldExtensionOpcode, FriOpcode, NativeBranchEqualOpcode,
-    NativeJalOpcode, NativeLoadStore4Opcode, NativeLoadStoreOpcode, NativePhantom,
-    NativeRangeCheckOpcode, Poseidon2Opcode, VerifyBatchOpcode, BLOCK_LOAD_STORE_SIZE,
+    CastfOpcode, FieldArithmeticOpcode, FieldExtensionOpcode, FriOpcode, NativeBranchEqualOpcode, NativeJalOpcode, NativeLoadStore4Opcode, NativeLoadStoreOpcode, NativePhantom, NativeRangeCheckOpcode, Poseidon2Opcode, SumcheckOpcode, VerifyBatchOpcode, BLOCK_LOAD_STORE_SIZE
 };
 use openvm_poseidon2_air::Poseidon2Config;
 use openvm_rv32im_circuit::{
@@ -29,10 +27,7 @@ use serde::{Deserialize, Serialize};
 use strum::IntoEnumIterator;
 
 use crate::{
-    adapters::{convert_adapter::ConvertAdapterChip, *},
-    poseidon2::chip::NativePoseidon2Chip,
-    phantom::*,
-    *,
+    adapters::{convert_adapter::ConvertAdapterChip, *}, phantom::*, poseidon2::chip::NativePoseidon2Chip, sumcheck::chip::NativeSumcheckChip, *
 };
 
 #[derive(Clone, Debug, Serialize, Deserialize, VmConfig, derive_new::new)]
@@ -76,6 +71,7 @@ pub enum NativeExecutor<F: PrimeField32> {
     FieldExtension(FieldExtensionChip<F>),
     FriReducedOpening(FriReducedOpeningChip<F>),
     VerifyBatch(NativePoseidon2Chip<F, 1>),
+    SumcheckLayerEval(NativeSumcheckChip<F>),
 }
 
 #[derive(From, ChipUsageGetter, Chip, AnyEnum)]
@@ -207,6 +203,17 @@ impl<F: PrimeField32> VmExtension<F> for Native {
             ],
         )?;
 
+        let sumcheck_chip = NativeSumcheckChip::new(
+            builder.system_port(),
+            offline_memory.clone(),
+        );
+        inventory.add_executor(
+            sumcheck_chip,
+            [
+                SumcheckOpcode::SUMCHECK_LAYER_EVAL.global_opcode(),
+            ]
+        )?;
+        
         builder.add_phantom_sub_executor(
             NativeHintInputSubEx,
             PhantomDiscriminant(NativePhantom::HintInput as u16),

extensions/native/circuit/src/field_extension/core.rs

@@ -245,10 +245,10 @@ impl FieldExtension {
 
     pub(crate) fn add<V, E>(x: [V; EXT_DEG], y: [V; EXT_DEG]) -> [E; EXT_DEG]
     where
-        V: Copy,
+        V: Clone,
         V: Add<V, Output = E>,
     {
-        array::from_fn(|i| x[i] + y[i])
+        array::from_fn(|i| x[i].clone() + y[i].clone())
     }
 
     pub(crate) fn subtract<V, E>(x: [V; EXT_DEG], y: [V; EXT_DEG]) -> [E; EXT_DEG]

extensions/native/circuit/src/fri/mod.rs

@@ -538,7 +538,7 @@ fn assert_array_eq<AB: AirBuilder, I1: Into<AB::Expr>, I2: Into<AB::Expr>, const
     }
 }
 
-fn elem_to_ext<F: Field>(elem: F) -> [F; EXT_DEG] {
+pub fn elem_to_ext<F: Field>(elem: F) -> [F; EXT_DEG] {
     let mut ret = [F::ZERO; EXT_DEG];
     ret[0] = elem;
     ret

extensions/native/circuit/src/lib.rs

@@ -8,6 +8,7 @@ mod fri;
 mod jal;
 mod loadstore;
 mod poseidon2;
+mod sumcheck;
 
 pub use branch_eq::*;
 pub use castf::*;
@@ -17,6 +18,7 @@ pub use fri::*;
 pub use jal::*;
 pub use loadstore::*;
 pub use poseidon2::*;
+pub use sumcheck::*;
 
 mod extension;
 pub use extension::*;

extensions/native/circuit/src/poseidon2/trace.rs

@@ -15,9 +15,9 @@ use openvm_stark_backend::{
 };
 
 use crate::{
-    chip::TranscriptObservationRecord, poseidon2::{
+    poseidon2::{
         chip::{
-            CellRecord, IncorporateRowRecord, IncorporateSiblingRecord, InsideRowRecord, NativePoseidon2Chip, SimplePoseidonRecord, VerifyBatchRecord, NUM_INITIAL_READS
+            TranscriptObservationRecord, CellRecord, IncorporateRowRecord, IncorporateSiblingRecord, InsideRowRecord, NativePoseidon2Chip, SimplePoseidonRecord, VerifyBatchRecord, NUM_INITIAL_READS
         },
         columns::{
             InsideRowSpecificCols, MultiObserveCols, NativePoseidon2Cols, SimplePoseidonSpecificCols, TopLevelSpecificCols