Skip to content

Commit 61d5c38

Browse files
authored
perf: skipping computing compression ratio for l1 messages (#345)
* perf: skipping computing compression ratio for l1 messages * refactor: updating compression_ratio expression to lazy evaluation * fix: refactored closure function for compute_compression_ratio
1 parent d590bf0 commit 61d5c38

File tree

1 file changed

+7
-4
lines changed
  • crates/scroll/alloy/evm/src/tx

1 file changed

+7
-4
lines changed

crates/scroll/alloy/evm/src/tx/mod.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,9 @@ impl FromTxWithEncoded<ScrollTxEnvelope> for ScrollTransactionIntoTxEnv<TxEnv> {
161161

162162
let encoded = (!tx.is_l1_message()).then_some(encoded);
163163
// Note: We compute the transaction ratio on tx.data, not on the full encoded transaction.
164-
let compression_ratio = compute_compression_ratio(base.input());
165-
Self::new(base, encoded, Some(compression_ratio))
164+
let compression_ratio =
165+
(!tx.is_l1_message()).then(|| compute_compression_ratio(base.input()));
166+
Self::new(base, encoded, compression_ratio)
166167
}
167168
}
168169

@@ -270,7 +271,9 @@ impl FromRecoveredTx<ScrollTxEnvelope> for ScrollTransactionIntoTxEnv<TxEnv> {
270271

271272
let encoded = (!tx.is_l1_message()).then_some(envelope.into());
272273
// Note: We compute the transaction ratio on tx.data, not on the full encoded transaction.
273-
let compression_ratio = compute_compression_ratio(base.input());
274-
Self::new(base, encoded, Some(compression_ratio))
274+
let compression_ratio =
275+
(!tx.is_l1_message()).then(|| compute_compression_ratio(base.input()));
276+
277+
Self::new(base, encoded, compression_ratio)
275278
}
276279
}

0 commit comments

Comments
 (0)