fix: answer comments

Signed-off-by: Gregory Edison <[email protected]>

Author: greged93

crates/optimism/payload/Cargo.toml

@@ -60,4 +60,4 @@ optimism = [
 	"reth-execution-types/optimism",
 	"reth-optimism-consensus/optimism"
 ]
-scroll = []
+scroll = []

crates/primitives/src/transaction/mod.rs

@@ -425,7 +425,7 @@ impl Transaction {
     /// Returns true if the transaction is a Scroll L1 messaging transaction.
     #[cfg(all(feature = "scroll", not(feature = "optimism")))]
     #[inline]
-    pub fn is_l1_messaging(&self) -> bool {
+    pub fn is_l1_message(&self) -> bool {
         matches!(self, Self::L1Message(_))
     }
 
@@ -1741,7 +1741,7 @@ impl<'a> arbitrary::Arbitrary<'a> for TransactionSigned {
         let signature = if transaction.is_deposit() { TxDeposit::signature() } else { signature };
         #[cfg(all(feature = "scroll", not(feature = "optimism")))]
         let signature =
-            if transaction.is_l1_messaging() { TxL1Message::signature() } else { signature };
+            if transaction.is_l1_message() { TxL1Message::signature() } else { signature };
 
         Ok(Self::new_unhashed(transaction, signature))
     }

crates/scroll/primitives/src/l1_transaction.rs

@@ -11,8 +11,8 @@ use serde::{Deserialize, Serialize};
 #[cfg(any(test, feature = "reth-codec"))]
 use {reth_codecs::Compact, reth_codecs_derive::add_arbitrary_tests};
 
-/// L1 message transaction type id.
-pub const L1_MESSAGE_TRANSACTION_TYPE: u8 = 0x7E;
+/// L1 message transaction type id, 0x7e in hex.
+pub const L1_MESSAGE_TRANSACTION_TYPE: u8 = 126;
 
 /// A message transaction sent from the settlement layer to the L2 for execution.
 ///