feat: import zstd encoder crate from da-codec repository (#303)

* feat: import zstd encoder from da-codec

* fix: ci

* address comment

* deny allow da-codec

* chore: fix clippy docs (paradigmxyz#17726)

Co-authored-by: Alexey Shekhirin <[email protected]>

* ignore da-codec license check

* cargo update

---------

Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>

Author: 3 people

Cargo.lock

@@ -613,6 +613,7 @@ mini-moka = "0.10"
 tar-no-std = { version = "0.3.2", default-features = false }
 miniz_oxide = { version = "0.8.4", default-features = false }
 chrono = "0.4.41"
+encoder-standard = { git = "https://github.com/scroll-tech/da-codec", default-features = false }
 
 # metrics
 metrics = "0.24.0"

Cargo.toml

@@ -2582,8 +2582,8 @@ pub enum BlockStatus {
 
 /// How a payload was inserted if it was valid.
 ///
-/// If the payload was valid, but has already been seen, [`InsertPayloadOk::AlreadySeen(_)`] is
-/// returned, otherwise [`InsertPayloadOk::Inserted(_)`] is returned.
+/// If the payload was valid, but has already been seen, [`InsertPayloadOk::AlreadySeen`] is
+/// returned, otherwise [`InsertPayloadOk::Inserted`] is returned.
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
 pub enum InsertPayloadOk {
     /// The payload was valid, but we have already seen it.

crates/engine/tree/src/tree/mod.rs

@@ -143,7 +143,7 @@ where
     /// Max requests to handle at the same time
     ///
     /// This depends on the number of active peers but will always be
-    /// [`min_concurrent_requests`..`max_concurrent_requests`]
+    /// `min_concurrent_requests..max_concurrent_requests`
     #[inline]
     fn concurrent_request_limit(&self) -> usize {
         let num_peers = self.client.num_connected_peers();

crates/net/downloaders/src/bodies/bodies.rs

@@ -148,7 +148,7 @@ where
     /// Max requests to handle at the same time
     ///
     /// This depends on the number of active peers but will always be
-    /// [`min_concurrent_requests`..`max_concurrent_requests`]
+    /// `min_concurrent_requests..max_concurrent_requests`
     #[inline]
     fn concurrent_request_limit(&self) -> usize {
         let num_peers = self.client.num_connected_peers();

crates/net/downloaders/src/headers/reverse_headers.rs

@@ -788,9 +788,9 @@ impl NetworkEventStream {
         peers
     }
 
-    /// Ensures that the first two events are a [`NetworkEvent::Peer(PeerEvent::PeerAdded`] and
-    /// [`NetworkEvent::ActivePeerSession`], returning the [`PeerId`] of the established
-    /// session.
+    /// Ensures that the first two events are a [`NetworkEvent::Peer`] and
+    /// [`PeerEvent::PeerAdded`][`NetworkEvent::ActivePeerSession`], returning the [`PeerId`] of the
+    /// established session.
     pub async fn peer_added_and_established(&mut self) -> Option<PeerId> {
         let peer_id = match self.inner.next().await {
             Some(NetworkEvent::Peer(PeerEvent::PeerAdded(peer_id))) => peer_id,

crates/net/network/src/test_utils/testnet.rs

@@ -61,8 +61,8 @@ pub struct PruningArgs {
     pub receipts_before: Option<BlockNumber>,
     // Receipts Log Filter
     /// Configure receipts log filter. Format:
-    /// <`address`>:<`prune_mode`>[,<`address`>:<`prune_mode`>...] Where <`prune_mode`> can be
-    /// 'full', 'distance:<`blocks`>', or 'before:<`block_number`>'
+    /// <`address`>:<`prune_mode`>... where <`prune_mode`> can be 'full', 'distance:<`blocks`>', or
+    /// 'before:<`block_number`>'
     #[arg(long = "prune.receiptslogfilter", value_name = "FILTER_CONFIG", conflicts_with_all = &["receipts_full", "receipts_pre_merge", "receipts_distance",  "receipts_before"], value_parser = parse_receipts_log_filter)]
     pub receipts_log_filter: Option<ReceiptsLogPruneConfig>,
 

crates/node/core/src/args/pruning.rs

@@ -156,9 +156,9 @@ impl PruneModes {
 /// left in database after the pruning.
 ///
 /// 1. For [`PruneMode::Full`], it fails if `MIN_BLOCKS > 0`.
-/// 2. For [`PruneMode::Distance(distance`)], it fails if `distance < MIN_BLOCKS + 1`. `+ 1` is
-///    needed because `PruneMode::Distance(0)` means that we leave zero blocks from the latest,
-///    meaning we have one block in the database.
+/// 2. For [`PruneMode::Distance`], it fails if `distance < MIN_BLOCKS + 1`. `+ 1` is needed because
+///    `PruneMode::Distance(0)` means that we leave zero blocks from the latest, meaning we have one
+///    block in the database.
 #[cfg(any(test, feature = "serde"))]
 fn deserialize_opt_prune_mode_with_min_blocks<
     'de,

crates/prune/types/src/target.rs

@@ -25,7 +25,7 @@ pub struct RpcTestCase {
 /// Action that runs RPC compatibility tests from execution-apis test data
 #[derive(Debug)]
 pub struct RunRpcCompatTests {
-    /// RPC methods to test (e.g., ["`eth_getLogs`"])
+    /// RPC methods to test (e.g. `eth_getLogs`)
     pub methods: Vec<String>,
     /// Path to the execution-apis tests directory
     pub test_data_path: String,

crates/rpc/rpc-e2e-tests/src/rpc_compat.rs

@@ -31,7 +31,7 @@ scroll-alloy-hardforks = { workspace = true, default-features = false }
 # misc
 auto_impl = { workspace = true, default-features = false }
 serde = { workspace = true, default-features = false, features = ["derive"], optional = true }
-zstd = { version = "=0.13.3", features = ["experimental"], default-features = false, optional = true }
+encoder-standard = { workspace = true, default-features = false, optional = true }
 
 [dev-dependencies]
 alloy-hardforks.workspace = true
@@ -69,4 +69,4 @@ serde = [
     "scroll-alloy-hardforks/serde",
     "alloy-hardforks/serde",
 ]
-zstd_compression = ["zstd"]
+zstd_compression = ["encoder-standard"]