Skip to content

Commit 05ca1a0

Browse files
committed
cleanup code
1 parent 5da8a46 commit 05ca1a0

File tree

5 files changed

+14
-41
lines changed

5 files changed

+14
-41
lines changed

crates/database/db/src/db.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,8 +1291,6 @@ mod test {
12911291
// Set up the test database.
12921292
let db = setup_test_db().await;
12931293

1294-
println!("im here");
1295-
12961294
// Generate unstructured bytes.
12971295
let mut bytes = [0u8; 1024];
12981296
rand::rng().fill(bytes.as_mut_slice());
@@ -1303,8 +1301,6 @@ mod test {
13031301
let batch_info: BatchInfo = batch_data.clone().into();
13041302
db.insert_batch(batch_data).await.unwrap();
13051303

1306-
println!("inserted batch");
1307-
13081304
// Generate and insert multiple L2 blocks
13091305
let mut block_infos = Vec::new();
13101306
for i in 200..205 {
@@ -1313,8 +1309,6 @@ mod test {
13131309
}
13141310
db.insert_blocks(block_infos.clone(), batch_info).await.unwrap();
13151311

1316-
println!("inserted blocks");
1317-
13181312
// Test getting existing blocks
13191313
for expected_block in block_infos {
13201314
let retrieved_block =

crates/database/migration/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ mod m20250411_072004_add_l2_block;
88
mod m20250616_223947_add_metadata;
99
mod m20250904_175949_block_signature;
1010
mod m20251028_110719_add_l1_block_table;
11-
mod m20251125_181536_add_batch_commit_index;
1211

1312
mod migration_info;
1413
pub use migration_info::{
@@ -29,7 +28,6 @@ impl<MI: MigrationInfo + Send + Sync + 'static> MigratorTrait for Migrator<MI> {
2928
Box::new(m20250616_223947_add_metadata::Migration),
3029
Box::new(m20250904_175949_block_signature::Migration),
3130
Box::new(m20251028_110719_add_l1_block_table::Migration),
32-
Box::new(m20251125_181536_add_batch_commit_index::Migration),
3331
]
3432
}
3533
}

crates/database/migration/src/m20220101_000001_create_batch_commit_table.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,20 @@ impl MigrationTrait for Migration {
109109
)
110110
.await?;
111111

112+
// Add a composite index on (status, finalized_block_number, index) for the `batch_commit`
113+
// table.
114+
manager
115+
.create_index(
116+
Index::create()
117+
.name("idx_batch_commit_status_finalized_block_number_index")
118+
.col(BatchCommit::Status)
119+
.col(BatchCommit::FinalizedBlockNumber)
120+
.col(BatchCommit::Index)
121+
.table(BatchCommit::Table)
122+
.to_owned(),
123+
)
124+
.await?;
125+
112126
Ok(())
113127
}
114128

crates/database/migration/src/m20251125_181536_add_batch_commit_index.rs

Lines changed: 0 additions & 28 deletions
This file was deleted.

crates/derivation-pipeline/src/cache.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,6 @@ impl PreFetchCache {
4848
&self,
4949
block_number: u64,
5050
) -> Result<Option<BlockDataHint>, DerivationPipelineError> {
51-
tracing::trace!(
52-
target: "scroll::derivation_pipeline::cache",
53-
block_number = block_number,
54-
"Fetching block data hint from cache",
55-
);
5651
// If the block number is beyond the maximum known block data hint, return None.
5752
if block_number > self.max_block_data_hint_block_number {
5853
return Ok(None);

0 commit comments

Comments
 (0)