address comment

Author: yiweichi

crates/node/src/args.rs

@@ -752,7 +752,7 @@ pub struct SignerArgs {
 #[derive(Debug, Default, Clone, clap::Args)]
 pub struct RpcArgs {
     /// A boolean to represent if the rollup node basic rpc should be enabled.
-    #[arg(long = "rpc.rollup-node", num_args=0..=1, default_value_t = true, help = "Enable the rollup node basic RPC namespace(default: true)")]
+    #[arg(long = "rpc.rollup-node", default_value_t = true, action = ArgAction::Set, help = "Enable the rollup node basic RPC namespace(default: true)")]
     pub basic_enabled: bool,
     /// A boolean to represent if the rollup node admin rpc should be enabled.
     #[arg(long = "rpc.rollup-node-admin", help = "Enable the rollup node admin RPC namespace")]

sequencer-migration/common-functions.sh

@@ -129,7 +129,7 @@ stop_l2geth_mining() {
 # Enable l2reth automatic sequencing
 enable_l2reth_sequencing() {
     log_info "Enabling L2RETH automatic sequencing..."
-    if cast rpc rollupNode_enableAutomaticSequencing --rpc-url "$L2RETH_RPC_URL" >/dev/null 2>&1; then
+    if cast rpc rollupNodeAdmin_enableAutomaticSequencing --rpc-url "$L2RETH_RPC_URL" >/dev/null 2>&1; then
         log_success "L2RETH automatic sequencing enabled"
         return 0
     else
@@ -141,7 +141,7 @@ enable_l2reth_sequencing() {
 # Disable l2reth automatic sequencing
 disable_l2reth_sequencing() {
     log_info "Disabling L2RETH automatic sequencing..."
-    if cast rpc rollupNode_disableAutomaticSequencing --rpc-url "$L2RETH_RPC_URL" >/dev/null 2>&1; then
+    if cast rpc rollupNodeAdmin_disableAutomaticSequencing --rpc-url "$L2RETH_RPC_URL" >/dev/null 2>&1; then
         log_success "L2RETH automatic sequencing disabled"
         return 0
     else

sequencer-migration/switch-to-l2reth.sh

@@ -18,7 +18,7 @@ perform_sequencing_switch() {
     # Phase 1: Disable L2GETH sequencing
     log_info "--- Phase 1: Disabling L2GETH sequencing ---"
     stop_l2geth_mining
-    
+
     # wait for l2reth to catch up with l2geth
     log_info "-- Phase 1.5: Waiting for L2RETH to catch up with L2GETH ---"
     wait_for_l2reth_to_catch_up_with_l2geth

tests/launch_rollup_node_follower.bash

@@ -8,7 +8,6 @@ exec rollup-node node --chain /l2reth/l2reth-genesis-e2e.json --datadir=/l2reth
   --network.valid_signer "0xb674ff99cca262c99d3eab5b32796a99188543da" \
   --http --http.addr=0.0.0.0 --http.port=8545 --http.corsdomain "*" --http.api admin,debug,eth,net,trace,txpool,web3,rpc,reth,ots,flashbots,miner,mev \
   --ws --ws.addr=0.0.0.0 --ws.port=8546 --ws.api admin,debug,eth,net,trace,txpool,web3,rpc,reth,ots,flashbots,miner,mev \
-  --rpc.rollup-node \
   --log.stdout.format log-fmt -vvv \
   --txpool.pending-max-count=1000 \
   --builder.gaslimit=30000000 \

tests/launch_rollup_node_sequencer.bash

@@ -15,7 +15,6 @@ exec rollup-node node --chain /l2reth/l2reth-genesis-e2e.json --datadir=/l2reth
   --network.valid_signer "0xb674ff99cca262c99d3eab5b32796a99188543da" \
   --http --http.addr=0.0.0.0 --http.port=8545 --http.corsdomain "*" --http.api admin,debug,eth,net,trace,txpool,web3,rpc,reth,ots,flashbots,miner,mev \
   --ws --ws.addr=0.0.0.0 --ws.port=8546 --ws.api admin,debug,eth,net,trace,txpool,web3,rpc,reth,ots,flashbots,miner,mev \
-  --rpc.rollup-node \
   --rpc.rollup-node-admin \
   --log.stdout.format log-fmt -vvv \
   --sequencer.enabled \

tests/src/utils.rs

@@ -66,7 +66,7 @@ sol! {
 pub async fn enable_automatic_sequencing(provider: &NamedProvider) -> Result<bool> {
     provider
         .client()
-        .request("rollupNode_enableAutomaticSequencing", ())
+        .request("rollupNodeAdminAdmin_enableAutomaticSequencing", ())
         .await
         .map_err(|e| eyre::eyre!("Failed to enable automatic sequencing: {}", e))
 }
@@ -75,7 +75,7 @@ pub async fn enable_automatic_sequencing(provider: &NamedProvider) -> Result<boo
 pub async fn disable_automatic_sequencing(provider: &NamedProvider) -> Result<bool> {
     provider
         .client()
-        .request("rollupNode_disableAutomaticSequencing", ())
+        .request("rollupNodeAdmin_disableAutomaticSequencing", ())
         .await
         .map_err(|e| eyre::eyre!("Failed to disable automatic sequencing: {}", e))
 }