feat(consensus): Add consensus check for block sequencing (#231)

* update tests

* remove println statement

* update consensus algorithm to noop in integration tests

* address comments

Author: frisitano

Cargo.lock

@@ -64,11 +64,12 @@ lint: fmt lint-toml clippy udeps codespell zepter
 
 .PHONY: test
 test:
-	cargo test \
+	cargo nextest run \
 	--workspace \
 	--locked \
 	--all-features \
-	--no-fail-fast
+	--no-fail-fast \
+	-E 'not test(docker)'
 
 # Used to update the mainnet-sample.sql data. Provide the path to the sqlite database that should be read from
 # using `DB_PATH`.

Makefile

@@ -15,6 +15,8 @@ pub trait Consensus: Send + Debug {
         block: &ScrollBlock,
         signature: &Signature,
     ) -> Result<(), ConsensusError>;
+    /// Returns a boolean indicating whether the sequencer should sequence a block.
+    fn should_sequence_block(&self, sequencer: &Address) -> bool;
 }
 
 /// A no-op consensus instance.
@@ -32,6 +34,10 @@ impl Consensus for NoopConsensus {
     ) -> Result<(), ConsensusError> {
         Ok(())
     }
+
+    fn should_sequence_block(&self, _sequencer: &Address) -> bool {
+        true
+    }
 }
 
 /// The system contract consensus.
@@ -71,6 +77,10 @@ impl Consensus for SystemContractConsensus {
         }
         Ok(())
     }
+
+    fn should_sequence_block(&self, sequencer: &Address) -> bool {
+        sequencer == &self.authorized_signer
+    }
 }
 
 #[cfg(test)]

crates/manager/src/consensus.rs

@@ -510,21 +510,22 @@ where
         proceed_if!(
             en_synced,
             // Check if we need to trigger the build of a new payload.
-            match (
-                this.block_building_trigger.as_mut().map(|x| x.poll_tick(cx)),
-                this.engine.is_payload_building_in_progress(),
+            if let (Some(Poll::Ready(_)), Some(sequencer)) = (
+                this.block_building_trigger.as_mut().map(|se| se.poll_tick(cx)),
+                this.sequencer.as_mut()
             ) {
-                (Some(Poll::Ready(_)), false) => {
-                    if let Some(sequencer) = this.sequencer.as_mut() {
-                        sequencer.build_payload_attributes();
-                    }
-                }
-                (Some(Poll::Ready(_)), true) => {
-                    // If the sequencer is already building a payload, we don't need to trigger it
-                    // again.
+                if !this.consensus.should_sequence_block(
+                    this.signer
+                        .as_ref()
+                        .map(|s| &s.address)
+                        .expect("signer must be set if sequencer is present"),
+                ) {
+                    trace!(target: "scroll::node::manager", "Signer is not authorized to sequence block for this slot");
+                } else if this.engine.is_payload_building_in_progress() {
                     warn!(target: "scroll::node::manager", "Payload building is already in progress skipping slot");
+                } else {
+                    sequencer.build_payload_attributes();
                 }
-                _ => {}
             }
         );
 

crates/manager/src/manager/mod.rs

@@ -95,6 +95,7 @@ futures.workspace = true
 reth-e2e-test-utils.workspace = true
 reth-node-core.workspace = true
 reth-provider.workspace = true
+reth-primitives-traits.workspace = true
 reth-rpc-server-types.workspace = true
 reth-scroll-node = { workspace = true, features = ["test-utils"] }
 reth-tasks.workspace = true
@@ -140,4 +141,6 @@ test-utils = [
     "scroll-alloy-rpc-types-engine",
     "alloy-rpc-types-engine",
     "scroll-derivation-pipeline",
+    "reth-primitives-traits/test-utils",
+    "reth-primitives-traits/test-utils",
 ]