feat: improve rpc namespace

Author: yiweichi

crates/node/src/add_ons/mod.rs

@@ -134,12 +134,12 @@ where
         let (tx, rx) = tokio::sync::oneshot::channel();
         let rpc_config = rollup_node_manager_addon.config().rpc_args.clone();
 
-        // Register rollupNode API and optionally rollupNodeAdmin API
+        // Register rollupNode API and rollupNodeAdmin API if enabled
         let rollup_node_rpc_ext = Arc::new(RollupNodeRpcExt::<N::Network>::new(rx));
 
         rpc_add_ons = rpc_add_ons.extend_rpc_modules(move |ctx| {
             // Always register rollupNode API (read-only operations)
-            if rpc_config.enabled {
+            if rpc_config.basic_enabled {
                 ctx.modules
                     .merge_configured(RollupNodeApiServer::into_rpc(rollup_node_rpc_ext.clone()))?;
             }
@@ -156,7 +156,7 @@ where
             rollup_node_manager_addon.launch(ctx.clone(), rpc_handle.clone()).await?;
 
         // Only send handle if RPC is enabled
-        if rpc_config.enabled || rpc_config.admin_enabled {
+        if rpc_config.basic_enabled || rpc_config.admin_enabled {
             tx.send(rollup_manager_handle.clone())
                 .map_err(|_| eyre::eyre!("failed to send rollup manager handle"))?;
         }

crates/node/src/add_ons/rpc.rs

@@ -59,7 +59,7 @@ where
     }
 }
 
-/// Defines the `rollupNode` JSON-RPC namespace for read-only operations.
+/// Defines the `rollupNode` JSON-RPC namespace for basic operations.
 ///
 /// This trait provides a custom RPC namespace that exposes rollup node status
 /// and query functionality to external clients. The namespace is exposed as `rollupNode`.

crates/node/src/args.rs

@@ -751,9 +751,9 @@ pub struct SignerArgs {
 /// The arguments for the rpc.
 #[derive(Debug, Default, Clone, clap::Args)]
 pub struct RpcArgs {
-    /// A boolean to represent if the rollup node rpc should be enabled.
-    #[arg(long = "rpc.rollup-node", num_args=0..=1, default_value_t = true, help = "Enable the rollup node RPC namespace(default: true)")]
-    pub enabled: bool,
+    /// A boolean to represent if the rollup node basic rpc should be enabled.
+    #[arg(long = "rpc.rollup-node", num_args=0..=1, default_value_t = true, help = "Enable the rollup node basic RPC namespace(default: true)")]
+    pub basic_enabled: bool,
     /// A boolean to represent if the rollup node admin rpc should be enabled.
     #[arg(long = "rpc.rollup-node-admin", help = "Enable the rollup node admin RPC namespace")]
     pub admin_enabled: bool,

crates/node/src/test_utils/fixture.rs

@@ -253,7 +253,7 @@ impl TestFixtureBuilder {
             gas_price_oracle_args: RollupNodeGasPriceOracleArgs::default(),
             consensus_args: ConsensusArgs::noop(),
             database: None,
-            rpc_args: RpcArgs { enabled: true, admin_enabled: true },
+            rpc_args: RpcArgs { basic_enabled: true, admin_enabled: true },
         }
     }
 

crates/node/src/test_utils/mod.rs

@@ -239,7 +239,7 @@ pub fn default_test_scroll_rollup_node_config() -> ScrollRollupNodeConfig {
         gas_price_oracle_args: crate::RollupNodeGasPriceOracleArgs::default(),
         consensus_args: ConsensusArgs::noop(),
         database: None,
-        rpc_args: RpcArgs { enabled: true, admin_enabled: true },
+        rpc_args: RpcArgs { basic_enabled: true, admin_enabled: true },
     }
 }
 
@@ -279,6 +279,6 @@ pub fn default_sequencer_test_scroll_rollup_node_config() -> ScrollRollupNodeCon
         gas_price_oracle_args: crate::RollupNodeGasPriceOracleArgs::default(),
         consensus_args: ConsensusArgs::noop(),
         database: None,
-        rpc_args: RpcArgs { enabled: true, admin_enabled: true },
+        rpc_args: RpcArgs { basic_enabled: true, admin_enabled: true },
     }
 }