Skip to content

Commit 0894618

Browse files
committed
comment fixes
1 parent eab4229 commit 0894618

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

common/testcontainers/testcontainers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ func (t *TestcontainerApps) GetPoSL1EndPoint() (string, error) {
167167
return contrainer.PortEndpoint(context.Background(), "8545/tcp", "http")
168168
}
169169

170-
// GetPoSL1Client returns a ethclient by dialing running PoS L1 client
170+
// GetPoSL1Client returns a raw rpc client and an ethclient by dialing the L1 node
171171
func (t *TestcontainerApps) GetPoSL1Client() (*rpc.Client, *ethclient.Client, error) {
172172
endpoint, err := t.GetPoSL1EndPoint()
173173
if err != nil {
@@ -223,7 +223,7 @@ func (t *TestcontainerApps) GetGormDBClient() (*gorm.DB, error) {
223223
return database.InitDB(dbCfg)
224224
}
225225

226-
// GetL2GethClient returns a ethclient by dialing running L2Geth
226+
// GetL2GethClient returns a raw rpc client and an ethclient by dialing the L2 node
227227
func (t *TestcontainerApps) GetL2GethClient() (*rpc.Client, *ethclient.Client, error) {
228228
rpcCli, err := t.GetL2Client()
229229
if err != nil {

rollup/internal/controller/sender/sender.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -841,9 +841,9 @@ func (s *Sender) getBlockNumberAndTimestampAndBaseFeeAndBlobFee(ctx context.Cont
841841
baseFee = header.BaseFee.Uint64()
842842
}
843843

844-
// Leave it up to the L1 node to return the correct blob base fee.
844+
// Leave it up to the L1 node to compute the correct blob base fee.
845845
// Previously we would compute it locally using `CalcBlobFee`, but
846-
// that needs to be in sync with the L1 node's configuration.
846+
// that approach requires syncing any future L1 configuration changes.
847847
// Note: The fetched blob base fee might not correspond to the block
848848
// that we fetched in the previous step, but this is acceptable.
849849
var hex hexutil.Big

rollup/internal/controller/watcher/l1_watcher.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import (
66
"fmt"
77
"math/big"
88

9-
"github.com/ethereum/go-ethereum/common/hexutil"
109
"github.com/prometheus/client_golang/prometheus"
10+
"github.com/scroll-tech/go-ethereum/common/hexutil"
1111
gethTypes "github.com/scroll-tech/go-ethereum/core/types"
1212
"github.com/scroll-tech/go-ethereum/ethclient"
1313
"github.com/scroll-tech/go-ethereum/log"
@@ -82,9 +82,9 @@ func (w *L1WatcherClient) FetchBlockHeader(blockHeight uint64) error {
8282
baseFee = block.BaseFee.Uint64()
8383
}
8484

85-
// Leave it up to the L1 node to return the correct blob base fee.
85+
// Leave it up to the L1 node to compute the correct blob base fee.
8686
// Previously we would compute it locally using `CalcBlobFee`, but
87-
// that needs to be in sync with the L1 node's configuration.
87+
// that approach requires syncing any future L1 configuration changes.
8888
// Note: The fetched blob base fee might not correspond to the block
8989
// that we fetched in the previous step, but this is acceptable.
9090
var hex hexutil.Big

0 commit comments

Comments
 (0)