Skip to content

Commit 1f05c6e

Browse files
yiweichicolinlyguo
andauthored
Apply suggestions from code review
Co-authored-by: colin <[email protected]>
1 parent 35f22b4 commit 1f05c6e

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

coordinator/internal/logic/auth/login.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func (l *LoginLogic) Check(login *types.LoginParameter) error {
112112
if login.Message.ProverProviderType == types.ProverProviderTypeUndefined {
113113
login.Message.ProverProviderType = types.ProverProviderTypeInternal
114114
} else {
115-
log.Error("invalid prover_provider_type", "value", login.Message.ProverProviderType, "prover name", login.Message.ProverName, "prover_version", login.Message.ProverVersion)
115+
log.Error("invalid prover_provider_type", "value", login.Message.ProverProviderType, "prover name", login.Message.ProverName, "prover version", login.Message.ProverVersion)
116116
return errors.New("invalid prover provider type.")
117117
}
118118
}

coordinator/internal/types/prover.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func (r ProverProviderType) String() string {
5151
case ProverProviderTypeExternal:
5252
return "prover provider type external"
5353
default:
54-
return fmt.Sprintf("prover provider type type: %d", r)
54+
return fmt.Sprintf("prover provider type: %d", r)
5555
}
5656
}
5757

coordinator/internal/utils/prover_name.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ func IsExternalProverNameMatch(localName, remoteName string) bool {
1010
return false
1111
}
1212

13-
// note the name of cloud prover is in fact in the format of "cloud_prover_{provider-name}_index"
13+
// note the name of cloud prover is in the format of "cloud_prover_{provider-name}_index"
1414
return local[0] == remote[0] && local[1] == remote[1] && local[2] == remote[2]
1515
}

0 commit comments

Comments
 (0)