Skip to content

Commit 6f60a8d

Browse files
committed
fix according to AI review
1 parent ce7dcaf commit 6f60a8d

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

coordinator/internal/logic/submitproof/proof_receiver.go

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ type ProofReceiverLogic struct {
7373
validateFailureProverTaskHaveVerifier prometheus.Counter
7474
proverSpeed *prometheus.GaugeVec
7575
provingTime prometheus.Gauge
76-
evm_cycle_per_gas prometheus.Gauge
76+
evmCyclePerGas prometheus.Gauge
7777

7878
ChunkTask provertask.ProverTask
7979
BundleTask provertask.ProverTask
@@ -137,7 +137,7 @@ func NewSubmitProofReceiverLogic(cfg *config.ProverManager, chainCfg *params.Cha
137137
Name: "coordinator_validate_failure_submit_have_been_verifier",
138138
Help: "Total number of submit proof validate failure proof have been verifier.",
139139
}),
140-
evm_cycle_per_gas: promauto.With(reg).NewGauge(prometheus.GaugeOpts{
140+
evmCyclePerGas: promauto.With(reg).NewGauge(prometheus.GaugeOpts{
141141
Name: "evm_circuit_cycle_per_gas",
142142
Help: "VM cycles cost for a gas unit cost in evm execution",
143143
}),
@@ -221,14 +221,16 @@ func (m *ProofReceiverLogic) HandleZkProof(ctx *gin.Context, proofParameter coor
221221
}
222222
success, verifyErr = m.verifier.VerifyChunkProof(chunkProof, hardForkName)
223223
if stat := chunkProof.VmProof.Stat; stat != nil {
224-
if g, _ := m.proverSpeed.GetMetricWithLabelValues("chunk", "exec"); g != nil {
224+
if g, _ := m.proverSpeed.GetMetricWithLabelValues("chunk", "exec"); g != nil && stat.ExecutionTimeMills > 0 {
225225
g.Set(float64(stat.TotalCycle) / float64(stat.ExecutionTimeMills*1000))
226226
}
227-
if g, _ := m.proverSpeed.GetMetricWithLabelValues("chunk", "proving"); g != nil {
227+
if g, _ := m.proverSpeed.GetMetricWithLabelValues("chunk", "proving"); g != nil && stat.ProvingTimeMills > 0 {
228228
g.Set(float64(stat.TotalCycle) / float64(stat.ProvingTimeMills*1000))
229229
}
230-
cycle_per_gas := float64(stat.TotalCycle) / float64(chunkProof.MetaData.TotalGasUsed)
231-
m.evm_cycle_per_gas.Set(cycle_per_gas)
230+
if chunkProof.MetaData.TotalGasUsed > 0 {
231+
cycle_per_gas := float64(stat.TotalCycle) / float64(chunkProof.MetaData.TotalGasUsed)
232+
m.evmCyclePerGas.Set(cycle_per_gas)
233+
}
232234
m.provingTime.Set(float64(stat.ProvingTimeMills) / 1000)
233235
}
234236

@@ -239,10 +241,10 @@ func (m *ProofReceiverLogic) HandleZkProof(ctx *gin.Context, proofParameter coor
239241
}
240242
success, verifyErr = m.verifier.VerifyBatchProof(batchProof, hardForkName)
241243
if stat := batchProof.VmProof.Stat; stat != nil {
242-
if g, _ := m.proverSpeed.GetMetricWithLabelValues("batch", "exec"); g != nil {
244+
if g, _ := m.proverSpeed.GetMetricWithLabelValues("batch", "exec"); g != nil && stat.ExecutionTimeMills > 0 {
243245
g.Set(float64(stat.TotalCycle) / float64(stat.ExecutionTimeMills*1000))
244246
}
245-
if g, _ := m.proverSpeed.GetMetricWithLabelValues("batch", "proving"); g != nil {
247+
if g, _ := m.proverSpeed.GetMetricWithLabelValues("batch", "proving"); g != nil && stat.ProvingTimeMills > 0 {
246248
g.Set(float64(stat.TotalCycle) / float64(stat.ProvingTimeMills*1000))
247249
}
248250
}

0 commit comments

Comments
 (0)