Skip to content

Commit 7b01c4a

Browse files
committed
fixing according to reviews
1 parent dc6d3af commit 7b01c4a

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

common/libzkp/impl/src/lib.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ fn _dump_vk(fork_name: *const c_char, file: *const c_char) {
8080
/// Represents the result of generating a universal task
8181
#[repr(C)]
8282
pub struct HandlingResult {
83-
ok: c_char,
84-
universal_task: *mut c_char,
85-
metadata: *mut c_char,
86-
expected_pi_hash: [c_char; 32],
83+
pub ok: bool,
84+
pub universal_task: *mut c_char,
85+
pub metadata: *mut c_char,
86+
pub expected_pi_hash: [u8; 32],
8787
}
8888

8989
/// # Safety
@@ -93,7 +93,7 @@ pub unsafe extern "C" fn gen_universal_task(
9393
_task: *const c_char,
9494
_fork_name: *const c_char,
9595
) -> HandlingResult {
96-
unimplemented!("next phase");
96+
unimplemented!("implementation will be added in later PRs");
9797
}
9898

9999
/// # Safety
@@ -117,7 +117,7 @@ pub unsafe extern "C" fn gen_wrapped_proof(
117117
_vk: *const c_char,
118118
_vk_len: usize,
119119
) -> *mut c_char {
120-
unimplemented!("next phase");
120+
unimplemented!("implementation will be added in later PRs");
121121
}
122122

123123
/// # Safety
@@ -131,5 +131,5 @@ pub unsafe extern "C" fn release_string(string_ptr: *mut c_char) {
131131
/// # Safety
132132
#[no_mangle]
133133
pub unsafe extern "C" fn init_l2geth(_config: *const c_char) {
134-
unimplemented!("next phase");
134+
unimplemented!("implementation will be added in later PRs");
135135
}

coordinator/internal/logic/provertask/prover_task.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ func (b *BaseProverTask) applyUniversal(schema *coordinatorType.GetTaskSchema) (
195195
return schema, nil
196196
}
197197

198-
ok, metadata, uTaskData, _ := libzkp.GenerateUniversalTask(schema.TaskType, schema.TaskData, schema.HardForkName)
198+
ok, uTaskData, metadata, _ := libzkp.GenerateUniversalTask(schema.TaskType, schema.TaskData, schema.HardForkName)
199199
if !ok {
200200
return nil, fmt.Errorf("can not generate universal task, see coordinator log for the reason")
201201
}

coordinator/internal/types/get_task.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ type GetTaskSchema struct {
1313
UUID string `json:"uuid"`
1414
TaskID string `json:"task_id"`
1515
TaskType int `json:"task_type"`
16+
UseSnark bool `json:"use_snark,omitempty"`
1617
TaskData string `json:"task_data"`
1718
HardForkName string `json:"hard_fork_name"`
1819
}

0 commit comments

Comments
 (0)