Skip to content

Commit 7eaa53c

Browse files
committed
resolve #1670
1 parent 3050ccb commit 7eaa53c

File tree

3 files changed

+32
-1
lines changed

3 files changed

+32
-1
lines changed

coordinator/internal/logic/provertask/batch_prover_task.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,16 @@ func (bp *BatchProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinato
8484
for i := 0; i < 5; i++ {
8585
var getTaskError error
8686
var tmpBatchTask *orm.Batch
87+
if getTaskParameter.TaskID != "" {
88+
tmpBatchTask, getTaskError = bp.batchOrm.GetBatchByHash(ctx.Copy(), getTaskParameter.TaskID)
89+
if getTaskError != nil {
90+
log.Error("failed to get expected batch", "taskID", taskCtx.hasAssignedTask.TaskID, "err", getTaskError)
91+
return nil, ErrCoordinatorInternalFailure
92+
} else if tmpBatchTask == nil {
93+
return nil, fmt.Errorf("Expected task (%s) is already dropped",
94+
taskCtx.hasAssignedTask.TaskID)
95+
}
96+
}
8797

8898
if taskCtx.hasAssignedTask != nil {
8999
tmpBatchTask, getTaskError = bp.batchOrm.GetBatchByHash(ctx.Copy(), taskCtx.hasAssignedTask.TaskID)

coordinator/internal/logic/provertask/bundle_prover_task.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,16 @@ func (bp *BundleProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinat
8282
for i := 0; i < 5; i++ {
8383
var getTaskError error
8484
var tmpBundleTask *orm.Bundle
85+
if getTaskParameter.TaskID != "" {
86+
tmpBundleTask, getTaskError = bp.bundleOrm.GetBundleByHash(ctx.Copy(), getTaskParameter.TaskID)
87+
if getTaskError != nil {
88+
log.Error("failed to get expected bundle", "taskID", taskCtx.hasAssignedTask.TaskID, "err", getTaskError)
89+
return nil, ErrCoordinatorInternalFailure
90+
} else if tmpBundleTask == nil {
91+
return nil, fmt.Errorf("Expected task (%s) is already dropped",
92+
taskCtx.hasAssignedTask.TaskID)
93+
}
94+
}
8595

8696
if taskCtx.hasAssignedTask != nil {
8797
tmpBundleTask, getTaskError = bp.bundleOrm.GetBundleByHash(ctx.Copy(), taskCtx.hasAssignedTask.TaskID)

coordinator/internal/logic/provertask/chunk_prover_task.go

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,17 @@ func (cp *ChunkProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinato
8080
for i := 0; i < 5; i++ {
8181
var getTaskError error
8282
var tmpChunkTask *orm.Chunk
83+
if getTaskParameter.TaskID != "" {
84+
tmpChunkTask, getTaskError = cp.chunkOrm.GetChunkByHash(ctx.Copy(), getTaskParameter.TaskID)
85+
if getTaskError != nil {
86+
log.Error("failed to get expected chunk", "taskID", taskCtx.hasAssignedTask.TaskID, "err", getTaskError)
87+
return nil, ErrCoordinatorInternalFailure
88+
} else if tmpChunkTask == nil {
89+
return nil, fmt.Errorf("Expected task (%s) is already dropped",
90+
taskCtx.hasAssignedTask.TaskID)
91+
}
92+
}
93+
8394
if taskCtx.hasAssignedTask != nil {
8495
log.Debug("retrieved assigned task chunk", "taskID", taskCtx.hasAssignedTask.TaskID, "prover", taskCtx.ProverName)
8596
tmpChunkTask, getTaskError = cp.chunkOrm.GetChunkByHash(ctx.Copy(), taskCtx.hasAssignedTask.TaskID)
@@ -221,7 +232,7 @@ func (cp *ChunkProverTask) formatProverTask(ctx context.Context, task *orm.Prove
221232
// Get block hashes.
222233
blockHashes, dbErr := cp.blockOrm.GetL2BlockHashesByChunkHash(ctx, task.TaskID)
223234
if dbErr != nil || len(blockHashes) == 0 {
224-
return nil, fmt.Errorf("failed to fetch block hashes of a chunk, chunk hash:%s err:%w", task.TaskID, dbErr)
235+
return nil, fmt.Errorf("failed to fetch block hashes of a chunk, chunk hash:%s err:%v", task.TaskID, dbErr)
225236
}
226237

227238
var taskDetailBytes []byte

0 commit comments

Comments
 (0)