Skip to content

Commit 819ded9

Browse files
committed
resume dep to rc.8 and skip ChallengeDigest field
Signed-off-by: noelwei <[email protected]>
1 parent 6c101f8 commit 819ded9

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

common/libzkp/impl/Cargo.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/libzkp/impl/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ ruint = { git = "https://github.com/scroll-tech/uint.git", branch = "v1.12.3" }
1414
tiny-keccak = { git = "https://github.com/scroll-tech/tiny-keccak", branch = "scroll-patch-v2.0.2-openvm-v1.0.0-rc.1" }
1515

1616
[dependencies]
17-
euclid_prover = { git = "https://github.com/scroll-tech/zkvm-prover.git", tag = "v0.1.0-rc.8.1", package = "scroll-zkvm-prover" }
18-
euclid_verifier = { git = "https://github.com/scroll-tech/zkvm-prover.git", tag = "v0.1.0-rc.8.1", package = "scroll-zkvm-verifier" }
17+
euclid_prover = { git = "https://github.com/scroll-tech/zkvm-prover.git", tag = "v0.1.0-rc.8", package = "scroll-zkvm-prover" }
18+
euclid_verifier = { git = "https://github.com/scroll-tech/zkvm-prover.git", tag = "v0.1.0-rc.8", package = "scroll-zkvm-verifier" }
1919

2020
base64 = "0.13.0"
2121
env_logger = "0.9.0"

common/types/message/message.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ type BatchTaskDetail struct {
9696
ChunkProofs []ChunkProof `json:"chunk_proofs"`
9797
BatchHeader interface{} `json:"batch_header"`
9898
BlobBytes []byte `json:"blob_bytes"`
99-
KzgProof Byte48 `json:"kzg_proof"`
100-
KzgCommitment Byte48 `json:"kzg_commitment"`
101-
ChallengeDigest common.Hash `json:"challenge_digest"`
99+
KzgProof Byte48 `json:"kzg_proof,omitempty"`
100+
KzgCommitment Byte48 `json:"kzg_commitment,omitempty"`
101+
ChallengeDigest common.Hash `json:"challenge_digest,omitempty"`
102102
}
103103

104104
// BundleTaskDetail consists of all the information required to describe the task to generate a proof for a bundle of batches.

coordinator/internal/logic/provertask/batch_prover_task.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,8 @@ func (bp *BatchProverTask) getBatchTaskDetail(dbBatch *orm.Batch, chunkInfos []*
292292
taskDetail.KzgCommitment = message.Byte48{Big: hexutil.Big(*new(big.Int).SetBytes(dbBatch.BlobDataProof[64:112]))}
293293
// FIXME: Challenge = ChallengeDigest % BLS_MODULUS, get the original ChallengeDigest.
294294
// Currently this is bypassed by disabling the sanity checks in the prover.
295-
taskDetail.ChallengeDigest = common.BytesToHash(dbBatch.BlobDataProof[0:32])
295+
// Simply omit the field now to skip sanity check in prover side
296+
// Resume it later (or FIXME has worked or the prover side has relax its checking)
297+
// taskDetail.ChallengeDigest = common.BytesToHash(dbBatch.BlobDataProof[0:32])
296298
return taskDetail, nil
297299
}

zkvm-prover/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ serde = { version = "1.0.198", features = ["derive"] }
1818
serde_json = "1.0.116"
1919
futures = "0.3.30"
2020

21-
scroll-zkvm-prover = { git = "https://github.com/scroll-tech/zkvm-prover", tag = "v0.1.0-rc.8.1" }
21+
scroll-zkvm-prover = { git = "https://github.com/scroll-tech/zkvm-prover", tag = "v0.1.0-rc.8" }
2222
ethers-core = { git = "https://github.com/scroll-tech/ethers-rs.git", branch = "v2.0.7" }
2323
ethers-providers = { git = "https://github.com/scroll-tech/ethers-rs.git", branch = "v2.0.7" }
2424
scroll-proving-sdk = { git = "https://github.com/scroll-tech/scroll-proving-sdk.git", rev = "af95d2a", features = [

0 commit comments

Comments
 (0)