check invalid config

Author: Thegaram

rollup/cmd/gas_oracle/app/app.go

@@ -66,18 +66,26 @@ func action(ctx *cli.Context) error {
 	registry := prometheus.DefaultRegisterer
 	observability.Server(ctx, db)
 
+	// Init L1 connection
 	l1RpcClient, err := rpc.Dial(cfg.L1Config.Endpoint)
 	if err != nil {
 		log.Crit("failed to dial raw RPC client to L1 endpoint", "endpoint", cfg.L1Config.Endpoint, "error", err)
 	}
 	l1client := ethclient.NewClient(l1RpcClient)
 
+	// sanity check config
+	if cfg.L1Config.RelayerConfig.GasOracleConfig.L1BaseFeeLimit == 0 || cfg.L1Config.RelayerConfig.GasOracleConfig.L1BlobBaseFeeLimit == 0 {
+		log.Crit("gas-oracle `l1_base_fee_limit` and `l1_blob_base_fee_limit` configs must be set")
+	}
+
+	// Init watcher and relayer
 	l1watcher := watcher.NewL1WatcherClient(ctx.Context, l1RpcClient, cfg.L1Config.StartHeight, db, registry)
 
 	l1relayer, err := relayer.NewLayer1Relayer(ctx.Context, db, cfg.L1Config.RelayerConfig, relayer.ServiceTypeL1GasOracle, registry)
 	if err != nil {
 		log.Crit("failed to create new l1 relayer", "config file", cfgFile, "error", err)
 	}
+
 	// Start l1 watcher process
 	go utils.LoopWithContext(subCtx, 10*time.Second, func(ctx context.Context) {
 		// Fetch the latest block number to decrease the delay when fetching gas prices

rollup/internal/controller/relayer/l1_relayer.go

@@ -174,13 +174,13 @@ func (r *Layer1Relayer) ProcessGasPriceOracle() {
 				return
 			}
 			// Cap base fee update at the configured upper limit
-			if limit := r.cfg.GasOracleConfig.L1BaseFeeLimit; limit > 0 && baseFee > limit {
+			if limit := r.cfg.GasOracleConfig.L1BaseFeeLimit; baseFee > limit {
 				log.Error("L1 base fee exceed max limit, set to max limit", "baseFee", baseFee, "maxLimit", limit)
 				r.metrics.rollupL1RelayerGasPriceOracleFeeOverLimitTotal.Inc()
 				baseFee = limit
 			}
 			// Cap blob base fee update at the configured upper limit
-			if limit := r.cfg.GasOracleConfig.L1BlobBaseFeeLimit; limit > 0 && blobBaseFee > limit {
+			if limit := r.cfg.GasOracleConfig.L1BlobBaseFeeLimit; blobBaseFee > limit {
 				log.Error("L1 blob base fee exceed max limit, set to max limit", "blobBaseFee", blobBaseFee, "maxLimit", limit)
 				r.metrics.rollupL1RelayerGasPriceOracleFeeOverLimitTotal.Inc()
 				blobBaseFee = limit