simplify version checks

Author: colinlyguo

common/version/prover_version.go

@@ -39,21 +39,33 @@ func CheckScrollRepoVersion(proverVersion, minVersion string) bool {
 		return CheckProverSDKWithMinVersion(proverVersion, minVersion)
 	}
 
-	c, err := semver.NewConstraint(">= " + minVersion + "-0")
+	proverVersionPrefix := extractVersionPrefix(proverVersion)
+	minVersionPrefix := extractVersionPrefix(minVersion)
+
+	c, err := semver.NewConstraint(">= " + minVersionPrefix + "-0")
 	if err != nil {
-		log.Error("failed to initialize constraint", "minVersion", minVersion, "error", err)
+		log.Error("failed to initialize constraint", "minVersionPrefix", minVersionPrefix, "error", err)
 		return false
 	}
 
-	v, err := semver.NewVersion(proverVersion + "-z")
+	v, err := semver.NewVersion(proverVersionPrefix + "-z")
 	if err != nil {
-		log.Error("failed to parse version", "proverVersion", proverVersion, "error", err)
+		log.Error("failed to parse version", "proverVersion", proverVersionPrefix, "error", err)
 		return false
 	}
 
 	return c.Check(v)
 }
 
+func extractVersionPrefix(version string) string {
+	for i, r := range version {
+		if (r < '0' || r > '9') && r != '.' && r != 'v' {
+			return version[:i]
+		}
+	}
+	return version
+}
+
 // CheckProverSDKWithMinVersion check prover sdk version is at least the minimum required version, it simply returns true for now,
 // and more checks will be added as we evolve.
 func CheckProverSDKWithMinVersion(proverVersion string, minVersion string) bool {

common/version/prover_version_test.go

@@ -49,6 +49,7 @@ func TestCheckScrollRepoVersion(t *testing.T) {
 		{"v4.1.98-aaa-bbb-ccc", "v999.0.0", false},
 		{"v1.0.0", "v1.0.0", true},
 		{"v1.0.0-alpha", "v1.0.0-alpha", true},
+		{"v4.4.90-000000--", "v4.4.90-eb7c51fc-58cdda4-9929c6d", true},
 	}
 
 	for _, tt := range tests {