apply features in configuration

Author: noel2004

coordinator/internal/config/config.go

@@ -66,6 +66,7 @@ type AssetConfig struct {
 // VerifierConfig load zk verifier config.
 type VerifierConfig struct {
 	MinProverVersion string        `json:"min_prover_version"`
+	Features         string        `json:"features,omitempty"`
 	Verifiers        []AssetConfig `json:"verifiers"`
 }
 

coordinator/internal/logic/verifier/verifier.go

@@ -67,6 +67,9 @@ func NewVerifier(cfg *config.VerifierConfig) (*Verifier, error) {
 		return nil, err
 	}
 
+	if cfg.Features != "" {
+		libzkp.SetDynamicFeature(cfg.Features)
+	}
 	libzkp.InitVerifier(string(configBytes))
 
 	v := &Verifier{

crates/libzkp/src/lib.rs

@@ -12,10 +12,24 @@ use std::path::Path;
 use tasks::chunk_interpreter::{ChunkInterpreter, TryFromWithInterpreter};
 
 /// global features: use legacy encoding for witness
-pub(crate) static LEGACY_WITNESS_ENCODING: bool = false;
+static mut LEGACY_WITNESS_ENCODING: bool = false;
+pub(crate) fn witness_use_legacy_mode() -> bool {unsafe{LEGACY_WITNESS_ENCODING}}
 
-pub fn set_dynamic_feature(feats: &str){
 
+pub fn set_dynamic_feature(feats: &str){
+    for feat_s in feats.split(':') {
+
+        match feat_s.trim().to_lowercase().as_str() {
+            "legacy_witness" => {
+                tracing::info!("set witness encoding for legacy mode");
+                unsafe {
+                    // the function is only called while initialize step
+                    LEGACY_WITNESS_ENCODING = true;
+                }
+            }
+            s => tracing::warn!("unrecognized dynamic feature: {s}"),
+        }
+    }
 }
 
 

crates/libzkp/src/tasks/batch.rs

@@ -84,7 +84,7 @@ impl TryFrom<BatchProvingTask> for ProvingTask {
 
     fn try_from(value: BatchProvingTask) -> Result<Self> {
         let witness = value.build_guest_input();
-        let serialized_witness = if crate::LEGACY_WITNESS_ENCODING {
+        let serialized_witness = if crate::witness_use_legacy_mode() {
             let legacy_witness = LegacyBatchWitness::from(witness);
             to_rkyv_bytes::<RancorError>(&legacy_witness)?.into_vec()
         } else {

crates/libzkp/src/tasks/bundle.rs

@@ -70,7 +70,7 @@ impl TryFrom<BundleProvingTask> for ProvingTask {
 
     fn try_from(value: BundleProvingTask) -> Result<Self> {
         let witness = value.build_guest_input();
-        let serialized_witness = if crate::LEGACY_WITNESS_ENCODING {
+        let serialized_witness = if crate::witness_use_legacy_mode() {
             to_rkyv_bytes::<RancorError>(&witness)?.into_vec()
         } else {
             super::encode_task_to_witness(&witness)?

crates/libzkp/src/tasks/chunk.rs

@@ -68,7 +68,7 @@ impl TryFrom<ChunkProvingTask> for ProvingTask {
 
     fn try_from(value: ChunkProvingTask) -> Result<Self> {
         let witness = value.build_guest_input();
-        let serialized_witness = if crate::LEGACY_WITNESS_ENCODING {
+        let serialized_witness = if crate::witness_use_legacy_mode() {
             let legacy_witness = LegacyChunkWitness::from(witness);
             to_rkyv_bytes::<RancorError>(&legacy_witness)?.into_vec()
         } else {
@@ -146,6 +146,7 @@ impl ChunkProvingTask {
 
     /// this method check the validate of current task (there may be missing storage node)
     /// and try fixing it until everything is ok
+    #[deprecated]
     pub fn prepare_task_via_interpret(
         &mut self,
         interpreter: impl ChunkInterpreter,