Skip to content

Commit be0b120

Browse files
committed
Update to work with debug-toolbar 3.1
1 parent 29505cb commit be0b120

File tree

5 files changed

+32
-22
lines changed

5 files changed

+32
-22
lines changed

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def read(fname):
2424

2525
setup(
2626
name='django-mail-panel',
27-
version='1.2.5',
27+
version='3.1',
2828
description='A panel for django-debug-toolbar that allows for ' +
2929
'viewing of recently sent email.',
3030
url='https://github.com/scuml/django-mail-panel',
@@ -40,8 +40,8 @@ def read(fname):
4040
package_data={'': ['LICENSE']},
4141

4242
install_requires=[
43-
'django>=1.8',
44-
'django-debug-toolbar>=1.0',
43+
'django>=2.2',
44+
'django-debug-toolbar>=3.0',
4545
],
4646
include_package_data=True,
4747
zip_safe=False, # because we're including static files

src/mail_panel/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.1'
1+
__version__ = '3.1'

src/mail_panel/panels.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
from collections import OrderedDict
44
import datetime
55

6+
from django.templatetags.static import static
7+
68
try:
79
from debug_toolbar.panels import Panel
810
except ImportError:
@@ -23,6 +25,12 @@ class MailToolbarPanel(Panel):
2325
has_content = True
2426
mail_list = OrderedDict()
2527

28+
@property
29+
def scripts(self):
30+
scripts = super().scripts
31+
scripts.append(static("debug_toolbar/mail/toolbar.mail.js"))
32+
return scripts
33+
2634
def nav_title(self):
2735
return _('Mail')
2836

src/mail_panel/static/debug_toolbar/mail/toolbar.mail.js

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
function djmail_document_ready(f){
2-
if (document.attachEvent ? document.readyState === "complete" : document.readyState !== "loading"){
3-
f();
4-
} else {
5-
document.addEventListener('DOMContentLoaded', f);
6-
}
2+
if (document.readyState !== 'loading') {
3+
f();
4+
} else {
5+
document.addEventListener('DOMContentLoaded', f);
6+
}
77
}
88

99
function djmail_load(url, element, callback)
1010
{
11-
req = new XMLHttpRequest();
11+
var req = new XMLHttpRequest();
1212
req.open("GET", url, true);
1313
req.onload = function () {
1414
element.innerHTML = this.response;
@@ -25,32 +25,32 @@ djmail_document_ready(function(){
2525
var $qa = document.querySelectorAll.bind(document);
2626

2727
function resize_message() {
28-
new_height = window.innerHeight - $q("#djm_message_container").getBoundingClientRect().top + window.scrollY + window.pageYOffset -10
28+
let new_height = window.innerHeight - $q("#djm_message_container").getBoundingClientRect().top + window.scrollY + window.pageYOffset -10
2929
$q("#djm_message_container").style.height = new_height + "px";
30-
preview_height = new_height - $q("#djm_message_overview").style.height - 10;
30+
let preview_height = new_height - $q("#djm_message_overview").style.height - 10;
3131
$q("#djm_message_preview").style.height = preview_height;
3232
}
3333

3434
function update_count(){
35-
unread_text = '';
36-
unread_count = $qa(".djm-unread").length;
35+
var unread_text = '';
36+
var unread_count = $qa(".djm-unread").length;
3737
if (unread_count > 1)
3838
unread_text = unread_count + " unread messages";
3939
else if (unread_count == 1)
4040
unread_text = "1 unread message";
41-
sidebar_textbox = $q('.MailToolbarPanel small');
41+
var sidebar_textbox = $q('.MailToolbarPanel small');
4242
if (sidebar_textbox)
4343
sidebar_textbox.innerHTML = unread_text;
4444
}
4545
function load_message(element){
46-
message_id = element.id;
47-
url = element.getAttribute('url');
46+
let message_id = element.id;
47+
let url = element.getAttribute('url');
4848
$qa('.djm-mail-toolbar tr.selected').forEach(function(e) {
4949
e.classList.remove('selected')
5050
});
5151

5252
element.classList.add('selected');
53-
unread_marker = element.querySelector('.djm-unread');
53+
let unread_marker = element.querySelector('.djm-unread');
5454
if(unread_marker)
5555
unread_marker.remove()
5656

@@ -76,7 +76,7 @@ djmail_document_ready(function(){
7676
}
7777
var cache = {}
7878
function display_multipart(multipart_tab){
79-
url = multipart_tab.getAttribute('url');
79+
let url = multipart_tab.getAttribute('url');
8080
if(!url)
8181
return;
8282

@@ -98,7 +98,7 @@ djmail_document_ready(function(){
9898
request.onload = function() {
9999
if (request.status >= 200 && request.status < 400) {
100100
// Success!
101-
data = request.responseText;
101+
let data = request.responseText;
102102
cache[url] = data;
103103
$q("#djm_message_preview iframe").contentDocument.querySelector('html').innerHTML = data;
104104
}
@@ -109,7 +109,9 @@ djmail_document_ready(function(){
109109
}
110110

111111
$qa(".djm-message-row").forEach(function(e){
112+
console.info("e");
112113
e.addEventListener('click', function(){
114+
console.info("click", this);
113115
load_message(this);
114116
})
115117
});

src/mail_panel/templates/mail_panel/panel.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% load static %}
22
<link rel="stylesheet" href="{% static 'debug_toolbar/mail/mail_toolbar.css' %}" type="text/css" media="screen" />
3-
<script src="{% static 'debug_toolbar/mail/toolbar.mail.js' %}"></script>
3+
<script type="module" src="{% static 'debug_toolbar/mail/toolbar.mail.js' %}" async></script>
44

55
<div class='djm-mail-toolbar'>
66

@@ -44,4 +44,4 @@
4444
<div class="clearfix"></div>
4545
</div>
4646

47-
</div>
47+
</div>

0 commit comments

Comments
 (0)