Skip to content

Commit c72069e

Browse files
committed
remove seurat flavor
1 parent 7985cc2 commit c72069e

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

docs/release-notes/3653.feature.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add {attr}`scanpy.settings.preset` setting with two new presets: {attr}`~scanpy.settings.Preset.SeuratV5` and {attr}`~scanpy.settings.Preset.ScanpyV2Preview`. {smaller}`P Angerer`
1+
Add {attr}`scanpy.settings.preset` setting with the new preset {attr}`~scanpy.settings.Preset.ScanpyV2Preview` {smaller}`P Angerer`

src/scanpy/_settings/presets.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,12 @@ def _generate_next_value_(
124124
ScanpyV2Preview = auto()
125125
""": Scanpy 2.*’s feature default settings. (Preview: subject to change!)"""
126126

127-
SeuratV5 = auto()
128-
""": Try to match Seurat 5.* as closely as possible."""
129-
130127
@preset_property
131128
def highly_variable_genes() -> Mapping[Preset, HVGPreset]:
132129
"""Flavor for :func:`~scanpy.pp.highly_variable_genes`."""
133130
return {
134131
Preset.ScanpyV1: HVGPreset(flavor="seurat", return_df=False),
135132
Preset.ScanpyV2Preview: HVGPreset(flavor="seurat_v3_paper", return_df=True),
136-
Preset.SeuratV5: HVGPreset(flavor="seurat_v3_paper", return_df=True),
137133
}
138134

139135
@preset_property
@@ -142,7 +138,6 @@ def pca() -> Mapping[Preset, PcaPreset]:
142138
return {
143139
Preset.ScanpyV1: PcaPreset(key_added=None),
144140
Preset.ScanpyV2Preview: PcaPreset(key_added="pca"),
145-
Preset.SeuratV5: PcaPreset(key_added="pca"),
146141
}
147142

148143
@preset_property
@@ -153,9 +148,6 @@ def rank_genes_groups() -> Mapping[Preset, RankGenesGroupsPreset]:
153148
Preset.ScanpyV2Preview: RankGenesGroupsPreset(
154149
method="wilcoxon", mask_var=None
155150
),
156-
Preset.SeuratV5: RankGenesGroupsPreset(
157-
method="wilcoxon", mask_var="highly_variable"
158-
),
159151
}
160152

161153
@preset_property
@@ -164,7 +156,6 @@ def scale() -> Mapping[Preset, ScalePreset]:
164156
return {
165157
Preset.ScanpyV1: ScalePreset(zero_center=True),
166158
Preset.ScanpyV2Preview: ScalePreset(zero_center=None),
167-
Preset.SeuratV5: ScalePreset(zero_center=None),
168159
}
169160

170161
@preset_property
@@ -173,7 +164,6 @@ def score_genes() -> Mapping[Preset, ScoreGenesPreset]:
173164
return {
174165
Preset.ScanpyV1: ScoreGenesPreset(ctrl_as_ref=True),
175166
Preset.ScanpyV2Preview: ScoreGenesPreset(ctrl_as_ref=False),
176-
Preset.SeuratV5: ScoreGenesPreset(ctrl_as_ref=False),
177167
}
178168

179169
@preset_property
@@ -182,7 +172,6 @@ def leiden() -> Mapping[Preset, LeidenPreset]:
182172
return {
183173
Preset.ScanpyV1: LeidenPreset(flavor="leidenalg"),
184174
Preset.ScanpyV2Preview: LeidenPreset(flavor="igraph"),
185-
Preset.SeuratV5: LeidenPreset(flavor="leidenalg"),
186175
}
187176

188177
@contextmanager
@@ -191,11 +180,11 @@ def override(self, preset: Preset) -> Generator[Preset, None, None]:
191180
192181
>>> import scanpy as sc
193182
>>> sc.settings.preset = sc.Preset.ScanpyV1
194-
>>> with sc.settings.preset.override(sc.Preset.SeuratV5):
183+
>>> with sc.settings.preset.override(sc.Preset.ScanpyV2Preview):
195184
... sc.settings.preset
196-
<Preset.SeuratV5: 'seuratv5'>
185+
<Preset.ScanpyV2Preview: 'scanpy-v2-preview'>
197186
>>> sc.settings.preset
198-
<Preset.ScanpyV1: 'scanpyv1'>
187+
<Preset.ScanpyV1: 'scanpy-v1'>
199188
"""
200189
from scanpy import settings
201190

0 commit comments

Comments
 (0)