Skip to content

Commit 33f6baf

Browse files
committed
IT: negated qualification of MetricsTests
As we now run more tests from the MetricsTests suite than not, it makes sense to negate the qualification of the tests, so that we say that we run the whole suite _except_ two tests. This way of specifying disabled tests explicitly makes them more discoverable for further development, so that we can easier see what's not yet supported and/or tested.
1 parent 173a6e4 commit 33f6baf

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

Makefile

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,7 @@ SCYLLA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
3535
:ExecutionProfileTest.*\
3636
:DCExecutionProfileTest.*\
3737
:DisconnectedNullStringApiArgsTest.*\
38-
:MetricsTests.Integration_Cassandra_ErrorsRequestTimeouts\
39-
:MetricsTests.Integration_Cassandra_ErrorsConnectionTimeouts\
40-
:MetricsTests.Integration_Cassandra_Requests\
41-
:MetricsTests.Integration_Cassandra_StatsShardConnections\
38+
:MetricsTests.*\
4239
:DcAwarePolicyTest.*\
4340
:-SchemaMetadataTest.Integration_Cassandra_RegularMetadataNotMarkedVirtual\
4441
:SchemaMetadataTest.Integration_Cassandra_VirtualMetadata\
@@ -52,6 +49,8 @@ SCYLLA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
5249
:ControlConnectionTests.Integration_Cassandra_TerminatedUsingMultipleIoThreadsWithError\
5350
:ServerSideFailureTests.Integration_Cassandra_ErrorFunctionFailure\
5451
:ServerSideFailureTests.Integration_Cassandra_ErrorFunctionAlreadyExists\
52+
:MetricsTests.Integration_Cassandra_StatsConnections\
53+
:MetricsTests.Integration_Cassandra_SpeculativeExecutionRequests\
5554
:*NoCompactEnabledConnection\
5655
:PreparedMetadataTests.Integration_Cassandra_AlterProperlyUpdatesColumnCount)
5756
endif
@@ -94,10 +93,7 @@ CASSANDRA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
9493
:ExecutionProfileTest.*\
9594
:DCExecutionProfileTest.*\
9695
:DisconnectedNullStringApiArgsTest.*\
97-
:MetricsTests.Integration_Cassandra_ErrorsRequestTimeouts\
98-
:MetricsTests.Integration_Cassandra_ErrorsConnectionTimeouts\
99-
:MetricsTests.Integration_Cassandra_Requests\
100-
:MetricsTests.Integration_Cassandra_StatsShardConnections\
96+
:MetricsTests.*\
10197
:DcAwarePolicyTest.*\
10298
:-PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare\
10399
:SchemaMetadataTest.Integration_Cassandra_RegularMetadataNotMarkedVirtual\
@@ -113,6 +109,8 @@ CASSANDRA_TEST_FILTER := $(subst ${SPACE},${EMPTY},ClusterTests.*\
113109
:ServerSideFailureTests.Integration_Cassandra_ErrorFunctionFailure\
114110
:ServerSideFailureTests.Integration_Cassandra_ErrorFunctionAlreadyExists\
115111
:SslTests.Integration_Cassandra_ReconnectAfterClusterCrashAndRestart\
112+
:MetricsTests.Integration_Cassandra_StatsConnections\
113+
:MetricsTests.Integration_Cassandra_SpeculativeExecutionRequests\
116114
:*NoCompactEnabledConnection\
117115
:PreparedMetadataTests.Integration_Cassandra_AlterProperlyUpdatesColumnCount)
118116
endif

0 commit comments

Comments
 (0)