codewide: enable additional type-related lints

This commit enables two additional lints in the Scylla Rust wrapper,
which have successfully caught some issues in the codebase:
- `unnameable_types`,
- `unreachable_pub`.
Both have already been used in the Rust Driver.

As some problems:
- either were not possible to be fixed, because they are caused by the
  bindgen-generated code,
- or would require a lot of changes in the codebase and are not
  worth it right now (e.g., `CassSession` and `CassRetryPolicy`),
this commit adds `#[expect(unnameable_types)]` and
`#[expect(unreachable_pub)]` attributes to the affected structs.

Author: wprzytula

scylla-rust-wrapper/Cargo.toml

@@ -60,6 +60,8 @@ strip = "none"
 
 [lints.rust]
 unsafe-op-in-unsafe-fn = "warn"
+unnameable_types = "warn"
+unreachable_pub = "warn"
 unexpected_cfgs = { level = "warn", check-cfg = [
     'cfg(cpp_integration_testing)',
 ] }

scylla-rust-wrapper/src/lib.rs

@@ -59,6 +59,7 @@ pub mod types {
     // for `cass_false` and `cass_true` globals.
     #![allow(non_upper_case_globals)]
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     // Definition for size_t (and possibly other types in the future)
     include_bindgen_generated!("basic_types.rs");
@@ -67,43 +68,56 @@ pub mod types {
 /// CassError, CassErrorSource, CassWriteType
 pub(crate) mod cass_error_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
+
     include_bindgen_generated!("cppdriver_error_types.rs");
 }
 
 /// CassValueType
 pub(crate) mod cass_data_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
+
     include_bindgen_generated!("cppdriver_data_types.rs");
 }
 
 /// CassConsistency
 pub(crate) mod cass_consistency_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
+
     include_bindgen_generated!("cppdriver_consistency_types.rs");
 }
 
 /// CassBatchType
 pub(crate) mod cass_batch_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
+
     include_bindgen_generated!("cppdriver_batch_types.rs");
 }
 
 /// CassCompressionType
 pub(crate) mod cass_compression_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
+
     include_bindgen_generated!("cppdriver_compression_types.rs");
 }
 
 /// CassCollectionType
 pub(crate) mod cass_collection_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
+
     include_bindgen_generated!("cppdriver_collection_types.rs");
 }
 
 /// CassInet
 pub(crate) mod cass_inet_types {
     #![allow(unused)]
     #![allow(non_camel_case_types, non_snake_case)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     include_bindgen_generated!("cppdriver_inet_types.rs");
 }
@@ -112,13 +126,15 @@ pub(crate) mod cass_inet_types {
 pub(crate) mod cass_log_types {
     #![allow(unused)]
     #![allow(non_camel_case_types, non_snake_case)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     include_bindgen_generated!("cppdriver_log_types.rs");
 }
 
 /// CassColumnType
 pub(crate) mod cass_column_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     include_bindgen_generated!("cppdriver_column_type.rs");
 }
@@ -127,13 +143,15 @@ pub(crate) mod cass_column_types {
 pub(crate) mod cass_uuid_types {
     #![allow(unused)]
     #![allow(non_camel_case_types, non_snake_case)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     include_bindgen_generated!("cppdriver_uuid_types.rs");
 }
 
 /// CassIteratorType
 pub(crate) mod cass_iterator_types {
     #![allow(unused)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     include_bindgen_generated!("cppdriver_iterator_types.rs");
 }
@@ -142,6 +160,7 @@ pub(crate) mod cass_iterator_types {
 pub(crate) mod cass_metrics_types {
     #![allow(unused)]
     #![allow(non_camel_case_types, non_snake_case)]
+    #![allow(unreachable_pub, unnameable_types)]
 
     include_bindgen_generated!("cppdriver_metrics_types.rs");
 }

scylla-rust-wrapper/src/retry_policy.rs

@@ -6,8 +6,13 @@ use std::sync::Arc;
 
 use crate::argconv::{ArcFFI, CMut, CassBorrowedSharedPtr, CassOwnedSharedPtr, FFI, FromArc};
 
+// Technically, we should not allow this struct to be public,
+// but this would require a lot of changes in the codebase:
+// CassRetryPolicy would need to be a newtype wrapper around
+// an additional inner enum.
+#[expect(unnameable_types)]
 #[derive(Debug)]
-pub(crate) struct CassLoggingRetryPolicy {
+pub struct CassLoggingRetryPolicy {
     child_policy: Arc<CassRetryPolicy>,
 }
 

scylla-rust-wrapper/src/session.rs

@@ -32,6 +32,11 @@ use std::sync::Arc;
 use std::time::Duration;
 use tokio::sync::RwLock;
 
+// Technically, we should not allow this struct to be public,
+// but this would require a lot of changes in the codebase:
+// CassSession would need to be a newtype wrapper around this struct
+// instead of a type alias.
+#[expect(unnameable_types)]
 pub struct CassSessionInner {
     session: Session,
     exec_profile_map: HashMap<ExecProfileName, ExecutionProfileHandle>,