Skip to content

Commit b33da6c

Browse files
committed
Review adjustments
1 parent a357efb commit b33da6c

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,7 @@ public enum DefaultDriverOption implements DriverOption {
675675
* <p>Value-type: boolean
676676
*/
677677
CONTROL_CONNECTION_RECONNECT_CONTACT_POINTS(
678-
"advanced.control-connection.reconnection.fallback-to-original-contacts"),
678+
"advanced.control-connection.reconnection.fallback-to-original-contact-points"),
679679

680680
/**
681681
* Whether `Session.prepare` calls should be sent to all nodes in the cluster.

core/src/main/java/com/datastax/oss/driver/internal/core/control/ControlConnection.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import com.datastax.oss.driver.api.core.auth.AuthenticationException;
2323
import com.datastax.oss.driver.api.core.config.DefaultDriverOption;
2424
import com.datastax.oss.driver.api.core.config.DriverConfig;
25+
import com.datastax.oss.driver.api.core.config.DriverExecutionProfile;
2526
import com.datastax.oss.driver.api.core.connection.ReconnectionPolicy;
2627
import com.datastax.oss.driver.api.core.loadbalancing.NodeDistance;
2728
import com.datastax.oss.driver.api.core.metadata.Node;
@@ -300,7 +301,10 @@ private void init(
300301
.withOwnerLogPrefix(logPrefix + "|control")
301302
.build();
302303

303-
Queue<Node> nodes = context.getLoadBalancingPolicyWrapper().newQueryPlan();
304+
Queue<Node> nodes =
305+
context
306+
.getLoadBalancingPolicyWrapper()
307+
.newQueryPlan(null, DriverExecutionProfile.DEFAULT_NAME, null);
304308

305309
connect(
306310
nodes,

core/src/main/java/com/datastax/oss/driver/internal/core/metadata/LoadBalancingPolicyWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public Queue<Node> newQueryPlan() {
169169
@NonNull
170170
public Queue<Node> newControlReconnectionQueryPlan() {
171171
// First try the original way
172-
Queue<Node> regularQueryPlan = newQueryPlan();
172+
Queue<Node> regularQueryPlan = newQueryPlan(null, DriverExecutionProfile.DEFAULT_NAME, null);
173173
if (!regularQueryPlan.isEmpty()) return regularQueryPlan;
174174

175175
if (context

core/src/main/resources/reference.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2122,7 +2122,7 @@ datastax-java-driver {
21222122
# Required: yes
21232123
# Modifiable at runtime: yes, the new value will be used for checks issued after the change.
21242124
# Overridable in a profile: no
2125-
fallback-to-original-contacts = false
2125+
fallback-to-original-contact-points = false
21262126
}
21272127
}
21282128

integration-tests/src/test/java/com/datastax/oss/driver/core/resolver/MockResolverIT.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -353,12 +353,6 @@ public void cannot_reconnect_with_resolved_socket() {
353353
break;
354354
}
355355
}
356-
/*
357-
ResultSet rs = session.execute("SELECT * FROM system.local");
358-
assertThat(rs).isNotNull();
359-
Row row = rs.one();
360-
assertThat(row).isNotNull();
361-
*/
362356
nodes = session.getMetadata().getNodes().values();
363357
assertThat(nodes).hasSize(3);
364358
Iterator<Node> iterator = nodes.iterator();

0 commit comments

Comments
 (0)