3.x: Expose scyllaVersion in additional classes, interfaces
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `getScyllaVersion()` to CCMAccess, CCMCache, ReadOnlyCCMAccess. Adds `scyllaVersion` field to CCMBridge.Builder class. Some tests for Scylla and Cassandra have very high code overlap. This change will make it possible to adjust a few lines in a method instead of repeating a whole test method with different cluster version requirement.
Bouncheck
force-pushed
the
scylla-3.x-test-fixes-StateListenerTest-CcmInterfaces
branch
from
105ac0f to
d4cb048
Compare
In newer Scylla versions ccm node decomission first causes DOWN event to be sent and then REMOVE. This change adjusts the expected event so that the test passes.
dkropachev
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
getScyllaVersion()to CCMAccess, CCMCache, ReadOnlyCCMAccess.Adds
scyllaVersionfield to CCMBridge.Builder class.Some tests for Scylla and Cassandra can have very high code overlap.
This change will make it possible to adjust a few lines in a method instead
of repeating the whole test method with different cluster version requirements.
This is bundled with adjustment to StateListenerTest:
In newer Scylla versions ccm node decomission first causes DOWN event
to be sent and then REMOVE. This change adjusts the expected event so that
the test passes.