Fix RemovedNodeIT random behavior #448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncheck
requested review from
dkropachev
and removed request for
dkropachev
Author
|
Test failed on CI unexpectedly when run with other tests, converting to draft. |
Collaborator
|
Seems like a workaround, but let's first vaerify if we need that workaround or is it a real issue on the server side / ccm. |
`RemovedNodeIt#should_signal_and_destroy_pool_when_node_gets_removed` test starts 4 node cluster. Probably because of nodes starting in parallel it sometimes leads to the situation where two nodes own the same token. This throws the test off. Not only the driver sees one node as invalid, but also the assertion that expects 4 different token ranges fails, because there are only 3. To remediate that this change modifies the test to start the setup with 1 node and then sequentially add remaining 3 nodes with their `initial_token` explicitly set. Due to issues with ccm choosing conflicting jmx_ports when starting nodes sequentially they are also set explicitly.
Bouncheck
force-pushed
the
fix-RemovedNodeIT-should_signal__removed-flaky
branch
from
686e996 to
0df288b
Compare
Author
|
Fixed (non-flaky) failures. It's ready for review in case it ends up being needed. |
|
Let's not guess, let's find where this issue comes from. |
|
Proper fix at scylladb/scylla-ccm#643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemovedNodeIt#should_signal_and_destroy_pool_when_node_gets_removedtest starts 4 node cluster. Probably because of nodes starting in parallel it sometimes leads to the situation where two nodes own the same token. This throws the test off. Not only the driver sees one node as invalid, but also the assertion that expects 4 different token ranges fails, because there are only 3.To remediate that this change modifies the test to start the setup with 1 node and then sequentially add remaining 3 nodes with their
initial_tokenexplicitly set.Fixes #393