HostConnectionPool pendingBorrows can be nil at closing #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SessionManager.replacePool adds pool to the pools map and only afterwards calls initAsync. For short period of time pool stays in `SessionManager.pools` uninitialized. If you close session in that exact time `HostConnectionPool.closeAsync` is going to endup in panic, because `pendingBorrows` is null : ``` java.lang.NullPointerException: null at com.datastax.driver.core.HostConnectionPool.closeAsync(HostConnectionPool.java:978) ```
dkropachev
force-pushed
the
dk/fix-host-connection-pool-close-async
branch
from
a04ad3c to
da759e5
Compare
dkropachev
added a commit
that referenced
this pull request
Mar 21, 2025
SessionManager.replacePool adds pool to the pools map and only afterwards calls initAsync. For short period of time pool stays in `SessionManager.pools` uninitialized. If you close session in that exact time `HostConnectionPool.closeAsync` is going to endup in panic, because `pendingBorrows` is null : ``` java.lang.NullPointerException: null at com.datastax.driver.core.HostConnectionPool.closeAsync(HostConnectionPool.java:978) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SessionManager.replacePooladds pool to the pools map and only afterwards calls.initAsyncon it.For short period of time pool stays in
SessionManager.poolsuninitialized.If you close session in that exact time
HostConnectionPool.closeAsyncis going to endup in panic, becausependingBorrowsis null :Fixes: #464