4.x: Make schema agreement query pull only columns that are used #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/fix-schema-agreement-query
branch
from
7df86ce to
ea2bf97
Compare
Bouncheck
requested changes
Mar 19, 2025
Bouncheck
left a comment
Bouncheck
left a comment
There was a problem hiding this comment.
Tests failed due to mocks expecting old call, but this will fail further down the line when checking peer validity which requires at least rpc address.
Just schema_version is not enough, but perhaps some stuff can be limited.
Currently schema agreement logic run `select * from system.peers`, while only `schema_version` is used, it creates excessive load on cluster and driver side.
dkropachev
force-pushed
the
dk/fix-schema-agreement-query
branch
from
ea2bf97 to
75214e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently schema agreement logic run
select * from system.peers, while onlyschema_versionis used, it creates excessive load on cluster and driver side.Fixes: #468