Don't log invalid row for zero-token nodes #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/3.x-dont-log-invalid-row-for-zero-token-nodes
branch
from
a751fe3 to
417df63
Compare
In some cases having zero token node is a normal thing. Logging invalid row each time driver updates metadata confuses users in such case and produce bad UX.
dkropachev
force-pushed
the
dk/3.x-dont-log-invalid-row-for-zero-token-nodes
branch
from
417df63 to
72e6dc2
Compare
Bouncheck
approved these changes
Apr 17, 2025
Bouncheck
left a comment
Bouncheck
left a comment
There was a problem hiding this comment.
It would be the best to have a way to differentiate valid zero-token nodes from broken nodes that did not receive tokens, but afaik there is no way to do that.
LGTM, but note that now the driver will never warn about the second case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases having zero token node is a normal thing.
Logging invalid row each time driver updates metadata confuses users in such case and produce bad UX.
Fixes: #520