Skip to content

Conversation

@dgarcia360
Copy link

This is a mandatory dependency update to resolve a critical Dependabot alert. For more details, see the Dependabot alerts.

This is a mandatory dependency update to resolve a critical Dependabot alert. For more details, see the [Dependabot alerts](https://docs.github.com/en/code-security/dependabot/dependabot-alerts/viewing-and-updating-dependabot-alerts).
@annastuchlik
Copy link

@Bouncheck @dkropachev Could you merge this? It fixes a security issue, see scylladb/scylladb#23935

@roydahan roydahan requested a review from Copilot April 28, 2025 13:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@roydahan roydahan requested a review from Bouncheck April 28, 2025 13:10
Copy link

@Bouncheck Bouncheck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I just did a cursory glance. I trust that all the versions and sha's are correct. I am not able to say much about the changes themselves.
Seems to work for me locally.

@Bouncheck Bouncheck merged commit 2f7d8f0 into scylladb:scylla-4.x Apr 28, 2025
9 of 11 checks passed
@Bouncheck
Copy link

Bouncheck commented Apr 28, 2025

@dgarcia360 this breaks make -C docs multiversion after all.
https://github.com/scylladb/java-driver/actions/runs/14710534817/job/41281516605

It looks like now a bunch of options for myst are required. First thing that appears is myst_enable_extensions but depending on what set of extensions is needed probably other options will be needed further down the line. At least that's what happened when i tried adding some options directly to conf.py.
Can you take a look at this? I'm assuming you are more familiar with sphinx related things.

@dgarcia360
Copy link
Author

@Bouncheck good catch! see #530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants