Remove DSE only continuous_paging_options feature

I'm not removing it entirely from the code, but ignoring it where it matters,
so it's essentially useless.

I think it's a reasonable balance between breaking the API of some classes
and removal of the feature.

Signed-off-by: Yaniv Kaul <[email protected]>

Author: mykaul

cassandra/cluster.py

@@ -4498,7 +4498,6 @@ class ResponseFuture(object):
     _timer = None
     _protocol_handler = ProtocolHandler
     _spec_execution_plan = NoSpeculativeExecutionPlan()
-    _continuous_paging_options = None
     _continuous_paging_session = None
     _host = None
 

cassandra/protocol.py

@@ -553,7 +553,6 @@ def __init__(self, query_params, consistency_level,
         self.paging_state = paging_state
         self.timestamp = timestamp
         self.skip_meta = skip_meta
-        self.continuous_paging_options = continuous_paging_options
         self.keyspace = keyspace
 
     def _write_query_params(self, f, protocol_version):
@@ -574,10 +573,6 @@ def _write_query_params(self, f, protocol_version):
         if self.timestamp is not None:
             flags |= _PROTOCOL_TIMESTAMP_FLAG
 
-        if self.continuous_paging_options:
-            raise UnsupportedOperation(
-                "Continuous paging may only be used with future protocol versions")
-
         if self.keyspace is not None:
             if ProtocolVersion.uses_keyspace_flag(protocol_version):
                 flags |= _WITH_KEYSPACE_FLAG
@@ -605,8 +600,6 @@ def _write_query_params(self, f, protocol_version):
             write_long(f, self.timestamp)
         if self.keyspace is not None:
             write_string(f, self.keyspace)
-        if self.continuous_paging_options:
-            self._write_paging_options(f, self.continuous_paging_options, protocol_version)
 
     def _write_paging_options(self, f, paging_options, protocol_version):
         write_int(f, paging_options.max_pages)

tests/integration/standard/test_custom_protocol_handler.py

@@ -121,37 +121,6 @@ def test_custom_raw_row_results_all_types(self):
         assert len(CustomResultMessageTracked.checked_rev_row_set) == len(PRIMITIVE_DATATYPES)-1
         cluster.shutdown()
 
-    @unittest.expectedFailure
-    @greaterthanorequalcass40
-    def test_protocol_divergence_v5_fail_by_continuous_paging(self):
-        """
-        Test to validate that V5 and DSE_V1 diverge. ContinuousPagingOptions is not supported by V5
-
-        @since DSE 2.0b3 GRAPH 1.0b1
-        @jira_ticket PYTHON-694
-        @expected_result NoHostAvailable will be risen when the continuous_paging_options parameter is set
-
-        @test_category connection
-        """
-        cluster = TestCluster(protocol_version=ProtocolVersion.V5, allow_beta_protocol_version=True)
-        session = cluster.connect()
-
-        max_pages = 4
-        max_pages_per_second = 3
-        continuous_paging_options = ContinuousPagingOptions(max_pages=max_pages,
-                                                            max_pages_per_second=max_pages_per_second)
-
-        future = self._send_query_message(session, timeout=session.default_timeout,
-                                        consistency_level=ConsistencyLevel.ONE,
-                            continuous_paging_options=continuous_paging_options)
-
-        # This should raise NoHostAvailable because continuous paging is not supported under ProtocolVersion.DSE_V1
-        with pytest.raises(NoHostAvailable) as context:
-            future.result()
-        assert "Continuous paging may only be used with protocol version ProtocolVersion.DSE_V1 or higher" in str(context.value)
-
-        cluster.shutdown()
-
     @greaterthanorequalcass30
     def test_protocol_divergence_v4_fail_by_flag_uses_int(self):
         """

tests/unit/test_protocol.py

@@ -91,25 +91,6 @@ def test_query_message(self):
     def _check_calls(self, io, expected):
         assert tuple(c[1] for c in io.write.mock_calls) == tuple(expected)
 
-    def test_continuous_paging(self):
-        """
-        Test to check continuous paging throws an Exception as it's not supported
-        @since DSE 2.0b3 GRAPH 1.0b1
-        @jira_ticket PYTHON-694
-        @expected_result the values are correctly written
-
-        @test_category connection
-        """
-        max_pages = 4
-        max_pages_per_second = 3
-        continuous_paging_options = ContinuousPagingOptions(max_pages=max_pages,
-                                                            max_pages_per_second=max_pages_per_second)
-        message = QueryMessage("a", 3, continuous_paging_options=continuous_paging_options)
-        io = Mock()
-        for version in ProtocolVersion.SUPPORTED_VERSIONS:
-            with pytest.raises(UnsupportedOperation):
-                message.send_body(io, version)
-
     def test_prepare_flag(self):
         """
         Test to check the prepare flag is properly set, This should only happen for V5 at the moment.