tests: mark test which are scylla specific

those test can't be run ontop of cassandra
and we should mark them in a why we can skip them

Author: fruch

tests/integration/__init__.py

@@ -394,12 +394,13 @@ def _id_and_mark(f):
                                             reason='Scylla does not support custom payloads. Cassandra requires native protocol v4.0+')
 xfail_scylla = lambda reason, *args, **kwargs: pytest.mark.xfail(SCYLLA_VERSION is not None, reason=reason, *args, **kwargs)
 incorrect_test = lambda reason='This test seems to be incorrect and should be fixed', *args, **kwargs: pytest.mark.xfail(reason=reason, *args, **kwargs)
+scylla_only = pytest.mark.skipif(SCYLLA_VERSION is None, reason='Scylla only test')
 
 pypy = unittest.skipUnless(platform.python_implementation() == "PyPy", "Test is skipped unless it's on PyPy")
 requiresmallclockgranularity = unittest.skipIf("Windows" in platform.system() or "asyncore" in EVENT_LOOP_MANAGER,
                                                "This test is not suitible for environments with large clock granularity")
 requiressimulacron = unittest.skipIf(SIMULACRON_JAR is None or CASSANDRA_VERSION < Version("2.1"), "Simulacron jar hasn't been specified or C* version is 2.0")
-requirecassandra = unittest.skipIf(DSE_VERSION, "Cassandra required")
+requirecassandra = unittest.skipIf(DSE_VERSION or SCYLLA_VERSION, "Cassandra required")
 notdse = unittest.skipIf(DSE_VERSION, "DSE not supported")
 requiredse = unittest.skipUnless(DSE_VERSION, "DSE required")
 requirescloudproxy = unittest.skipIf(CLOUD_PROXY_PATH is None, "Cloud Proxy path hasn't been specified")

tests/integration/standard/test_custom_protocol_handler.py

@@ -120,7 +120,6 @@ def test_custom_raw_row_results_all_types(self):
         self.assertEqual(len(CustomResultMessageTracked.checked_rev_row_set), len(PRIMITIVE_DATATYPES)-1)
         cluster.shutdown()
 
-    @unittest.expectedFailure
     @requirecassandra
     @greaterthanorequalcass40
     def test_protocol_divergence_v5_fail_by_continuous_paging(self):
@@ -168,7 +167,6 @@ def test_protocol_divergence_v4_fail_by_flag_uses_int(self):
         self._protocol_divergence_fail_by_flag_uses_int(ProtocolVersion.V4, uses_int_query_flag=False,
                                                         int_flag=True)
 
-    @unittest.expectedFailure
     @requirecassandra
     @greaterthanorequalcass40
     def test_protocol_v5_uses_flag_int(self):
@@ -196,7 +194,6 @@ def test_protocol_dsev1_uses_flag_int(self):
         self._protocol_divergence_fail_by_flag_uses_int(ProtocolVersion.DSE_V1, uses_int_query_flag=True,
                                                         int_flag=True)
 
-    @unittest.expectedFailure
     @requirecassandra
     @greaterthanorequalcass40
     def test_protocol_divergence_v5_fail_by_flag_uses_int(self):

tests/integration/standard/test_ip_change.py

@@ -5,7 +5,7 @@
 from cassandra.cluster import ExecutionProfile
 from cassandra.policies import WhiteListRoundRobinPolicy
 
-from tests.integration import use_cluster, get_node, get_cluster, local, TestCluster
+from tests.integration import use_cluster, get_node, get_cluster, local, TestCluster, scylla_only
 from tests.util import wait_until_not_raised
 
 LOGGER = logging.getLogger(__name__)
@@ -35,7 +35,7 @@ def test_change_address_during_live_session(self):
         LOGGER.debug("Change IP address for node3")
         ip_prefix = get_cluster().get_ipprefix()
         new_ip = f'{ip_prefix}33'
-        node3.set_configuration_options(values={'listen_address': new_ip, 'rpc_address': new_ip, 'api_address': new_ip})
+        node3.set_configuration_options(values={'listen_address': new_ip, 'rpc_address': new_ip})
         node3.network_interfaces = {k: (new_ip, v[1]) for k, v in node3.network_interfaces.items()}
         LOGGER.debug(f"Start node3 again with ip address {new_ip}")
         node3.start(wait_for_binary_proto=True)

tests/integration/standard/test_metadata.py

@@ -26,13 +26,13 @@
 
 from cassandra import AlreadyExists, SignatureDescriptor, UserFunctionDescriptor, UserAggregateDescriptor
 from cassandra.connection import Connection
-
 from cassandra.encoder import Encoder
 from cassandra.metadata import (IndexMetadata, Token, murmur3, Function, Aggregate, protect_name, protect_names,
                                 RegisteredTableExtension, _RegisteredExtensionType, get_schema_parser,
                                 group_keys_by_replica, NO_VALID_REPLICA)
 from cassandra.protocol import QueryMessage, ProtocolHandler
 from cassandra.util import SortedSet
+from ccmlib.scylla_cluster import ScyllaCluster
 
 from tests.integration import (get_cluster, use_singledc, PROTOCOL_VERSION, execute_until_pass,
                                BasicSegregatedKeyspaceUnitTestCase, BasicSharedKeyspaceUnitTestCase,
@@ -42,7 +42,8 @@
                                greaterthancass21, assert_startswith, greaterthanorequalcass40,
                                greaterthanorequaldse67, lessthancass40,
                                TestCluster, DSE_VERSION, requires_java_udf, requires_composite_type,
-                               requires_collection_indexes, SCYLLA_VERSION, xfail_scylla, xfail_scylla_version_lt)
+                               requires_collection_indexes, SCYLLA_VERSION, xfail_scylla, xfail_scylla_version_lt,
+                               scylla_only)
 
 from tests.util import wait_until
 
@@ -1279,13 +1280,13 @@ def test_already_exists_exceptions(self):
         cluster.shutdown()
 
     @local
-    @pytest.mark.xfail(reason='AssertionError: \'RAC1\' != \'r1\' - probably a bug in driver or in Scylla')
     def test_replicas(self):
         """
         Ensure cluster.metadata.get_replicas return correctly when not attached to keyspace
         """
         if murmur3 is None:
             raise unittest.SkipTest('the murmur3 extension is not available')
+        is_scylla = isinstance(get_cluster(), ScyllaCluster)
 
         cluster = TestCluster()
         self.assertEqual(cluster.metadata.get_replicas('test3rf', 'key'), [])
@@ -1295,7 +1296,7 @@ def test_replicas(self):
         self.assertNotEqual(list(cluster.metadata.get_replicas('test3rf', b'key')), [])
         host = list(cluster.metadata.get_replicas('test3rf', b'key'))[0]
         self.assertEqual(host.datacenter, 'dc1')
-        self.assertEqual(host.rack, 'r1')
+        self.assertEqual(host.rack, 'RAC1' if is_scylla else 'r1')
         cluster.shutdown()
 
     def test_token_map(self):
@@ -1334,7 +1335,7 @@ def test_token(self):
         self.assertEqual(expected_node_count, len(tmap.ring))
         cluster.shutdown()
 
-
+@scylla_only # this is scylla only, since the metadata timeout feature doesn't cover peers_v2 queries that is used by cassandra
 class MetadataTimeoutTest(unittest.TestCase):
     """
     Test of TokenMap creation and other behavior.

tests/integration/standard/test_rack_aware_policy.py

@@ -4,13 +4,17 @@
 from cassandra.cluster import Cluster
 from cassandra.policies import ConstantReconnectionPolicy, RackAwareRoundRobinPolicy
 
-from tests.integration import PROTOCOL_VERSION, get_cluster, use_multidc
+from tests.integration import PROTOCOL_VERSION, get_cluster, use_multidc, scylla_only
 
 LOGGER = logging.getLogger(__name__)
 
 def setup_module():
     use_multidc({'DC1': {'RC1': 2, 'RC2': 2}, 'DC2': {'RC1': 3}})
 
+# cassandra is failing in a weird way:
+#   Token allocation failed: the number of racks 2 in datacenter DC1 is lower than its replication factor 3.
+# for now just run it with scylla only
+@scylla_only
 class RackAwareRoundRobinPolicyTests(unittest.TestCase):
     @classmethod
     def setup_class(cls):

tests/integration/standard/test_rate_limit_exceeded.py

@@ -4,13 +4,14 @@
 from cassandra.cluster import Cluster
 from cassandra.policies import ConstantReconnectionPolicy, RoundRobinPolicy, TokenAwarePolicy
 
-from tests.integration import PROTOCOL_VERSION, use_cluster
+from tests.integration import PROTOCOL_VERSION, use_cluster, scylla_only
 
 LOGGER = logging.getLogger(__name__)
 
 def setup_module():
     use_cluster('rate_limit', [3], start=True)
 
+@scylla_only
 class TestRateLimitExceededException(unittest.TestCase):
     @classmethod
     def setup_class(cls):

tests/integration/standard/test_scylla_cloud.py

@@ -4,7 +4,7 @@
 from ccmlib.utils.ssl_utils import generate_ssl_stores
 from ccmlib.utils.sni_proxy import refresh_certs, get_cluster_info, start_sni_proxy, create_cloud_config
 
-from tests.integration import use_cluster
+from tests.integration import use_cluster, scylla_only
 from cassandra.cluster import Cluster, TwistedConnection
 
 
@@ -23,7 +23,7 @@
 # need to run them with specific configuration like `gevent.monkey.patch_all()` or under async functions
 # unsupported_connection_classes = [GeventConnection, AsyncioConnection, EventletConnection]
 
-
+@scylla_only
 class ScyllaCloudConfigTests(TestCase):
     def start_cluster_with_proxy(self):
         ccm_cluster = self.ccm_cluster

tests/integration/standard/test_shard_aware.py

@@ -32,7 +32,7 @@
 from cassandra.policies import TokenAwarePolicy, RoundRobinPolicy, ConstantReconnectionPolicy
 from cassandra import OperationTimedOut, ConsistencyLevel
 
-from tests.integration import use_cluster, get_node, PROTOCOL_VERSION
+from tests.integration import use_cluster, get_node, PROTOCOL_VERSION, scylla_only
 
 LOGGER = logging.getLogger(__name__)
 
@@ -42,6 +42,7 @@ def setup_module():
     use_cluster('shard_aware', [3], start=True)
 
 
+@scylla_only
 class TestShardAwareIntegration(unittest.TestCase):
     @classmethod
     def setup_class(cls):

tests/integration/standard/test_types.py

@@ -31,7 +31,7 @@
 
 from tests.integration import use_singledc, execute_until_pass, notprotocolv1, \
     BasicSharedKeyspaceUnitTestCase, greaterthancass21, lessthancass30, greaterthanorequaldse51, \
-    DSE_VERSION, greaterthanorequalcass3_10, requiredse, TestCluster, requires_composite_type
+    DSE_VERSION, greaterthanorequalcass3_10, requiredse, TestCluster, requires_composite_type, scylla_only
 from tests.integration.datatype_utils import update_datatypes, PRIMITIVE_DATATYPES, COLLECTION_TYPES, PRIMITIVE_DATATYPES_KEYS, \
     get_sample, get_all_samples, get_collection_sample
 
@@ -704,6 +704,7 @@ def test_can_insert_tuples_with_nulls(self):
         self.assertEqual(('', None, None, b''), result.one().t)
         self.assertEqual(('', None, None, b''), s.execute(read).one().t)
 
+    @scylla_only
     def test_insert_collection_with_null_fails(self):
         """
         NULLs in list / sets / maps are forbidden.