tests: fix test_bad_contact_point

since recent changes to metadata, on first round we remove all
host that we creating with unkown host_ids, so this test is failing
cause it's expects all the corrent  hosts to be available in the,
metadata, they would be available, but they were missing.

seems like we didn't update the peers with thier newly found host_ids
and hence they were remove (only a new phase of `refresh_node_list_and_token_map()`
would add them back to the hosts list), now that we update them
same as we update the local (control_connection host), test is working.

Author: fruch

cassandra/cluster.py

@@ -3921,6 +3921,8 @@ def _refresh_node_list_and_token_map(self, connection, preloaded_results=None,
             tokens = row.get("tokens", None)
             if partitioner and tokens and self._token_meta_enabled:
                 token_map[host] = tokens
+            self._cluster.metadata.update_host(host, old_endpoint=endpoint)
+
         for old_host_id, old_host in self._cluster.metadata.all_hosts_items():
             if old_host_id not in found_host_ids:
                 should_rebuild_token_map = True

tests/integration/standard/test_metadata.py

@@ -41,6 +41,7 @@
                                greaterthanorequaldse67, lessthancass40,
                                TestCluster, DSE_VERSION)
 
+from tests.util import wait_until
 
 log = logging.getLogger(__name__)
 
@@ -124,7 +125,12 @@ def test_bad_contact_point(self):
 
         @test_category metadata
         """
-        self.assertEqual(len(self.cluster.metadata.all_hosts()), 3)
+        # wait until we have only 3 hosts
+        wait_until(condition=lambda: len(self.cluster.metadata.all_hosts()) == 3, delay=0.5, max_attempts=5)
+
+        # verify the un-existing host was filtered
+        for host in self.cluster.metadata.all_hosts():
+            self.assertNotEquals(host.endpoint.address, '126.0.0.186')
 
 
 class SchemaMetadataTests(BasicSegregatedKeyspaceUnitTestCase):