Handle port passed as string to Cluster

If port number is passed as string the driver works but it starts
failing later on address search.

Check port passed as string is valid number and convert it to int.

Signed-off-by: Alejo Sanchez <[email protected]>

Author: Alejo Sanchez

cassandra/cluster.py

@@ -1144,6 +1144,13 @@ def __init__(self,
 
         Any of the mutable Cluster attributes may be set as keyword arguments to the constructor.
         """
+
+        # Handle port passed as string
+        if isinstance(port, str):
+            if not port.isdigit():
+                raise ValueError("Only numeric values are supported for port (%s)" % port)
+            port = int(port)
+
         if connection_class is not None:
             self.connection_class = connection_class
 

tests/unit/test_cluster.py

@@ -121,6 +121,16 @@ def test_requests_in_flight_threshold(self):
         for n in (0, mn, 128):
             self.assertRaises(ValueError, c.set_max_requests_per_connection, d, n)
 
+    def test_port_str(self):
+        """Check port passed as tring is converted and checked properly"""
+        cluster = Cluster(contact_points=['127.0.0.1'], port='1111')
+        for cp in cluster.endpoints_resolved:
+            if cp.address in ('::1', '127.0.0.1'):
+                self.assertEqual(cp.port, 1111)
+
+        with self.assertRaises(ValueError):
+            cluster = Cluster(contact_points=['127.0.0.1'], port='string')
+
 
 class SchedulerTest(unittest.TestCase):
     # TODO: this suite could be expanded; for now just adding a test covering a ticket