Clippy: Check also pub items

Turns out clippy has a terrible and shocking default: it won't make
suggestions that require introducing breaking changes.
This means that e.g. if we introduce a type which has a naming that
clippy would normally complain about, it won't if the type is pub!

For this reason we have many such types. This commit disables this
absurd default, and adds comment and attribute to each place affected by
this.

Author: Lorak-mmk

clippy.toml

@@ -0,0 +1 @@
+avoid-breaking-exported-api = false

scylla-cql/src/deserialize/frame_slice.rs

@@ -121,6 +121,9 @@ impl<'frame> FrameSlice<'frame> {
     /// Returns a new Bytes object which is a subslice of the original Bytes
     /// frame slice object.
     #[inline]
+    // Check triggers because `self` is `Copy`, so `to_` should take it by value.
+    // TODO(2.0): Take self by value.
+    #[expect(clippy::wrong_self_convention)]
     pub fn to_bytes(&self) -> Bytes {
         if self.original_frame.is_empty() {
             // For the borrowed, deficient version of FrameSlice - the one created with

scylla-cql/src/deserialize/value.rs

@@ -2167,6 +2167,9 @@ impl From<VectorDeserializationErrorKind> for BuiltinDeserializationErrorKind {
 /// Describes why deserialization of a map type failed.
 #[derive(Debug)]
 #[non_exhaustive]
+// Check triggers because all variants end with "DeserializationFailed".
+// TODO(2.0): Remove the "DeserializationFailed" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum MapDeserializationErrorKind {
     /// Failed to deserialize map's length.
     LengthDeserializationFailed(DeserializationError),

scylla-cql/src/frame/frame_errors.rs

@@ -130,6 +130,9 @@ pub enum CqlRequestSerializationError {
 /// server response fails.
 #[non_exhaustive]
 #[derive(Error, Debug, Clone)]
+// Check triggers because all variants begin with "Cql".
+// TODO(2.0): Remove the "Cql" prefix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum CqlResponseParseError {
     #[error("Failed to deserialize ERROR response: {0}")]
     CqlErrorParseError(#[from] CqlErrorParseError),
@@ -313,6 +316,9 @@ pub enum PreparedParseError {
 /// - paging state response
 #[non_exhaustive]
 #[derive(Debug, Error, Clone)]
+// Check triggers because all variants end with "ParseError".
+// TODO(2.0): Remove the "ParseError" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum RawRowsAndPagingStateResponseParseError {
     /// Failed to parse metadata flags.
     #[error("Malformed metadata flags: {0}")]
@@ -331,6 +337,9 @@ pub enum RawRowsAndPagingStateResponseParseError {
 /// of statement's prepared metadata failed.
 #[non_exhaustive]
 #[derive(Error, Debug, Clone)]
+// Check triggers because all variants end with "ParseError".
+// TODO(2.0): Remove the "ParseError" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum PreparedMetadataParseError {
     /// Failed to parse metadata flags.
     #[error("Malformed metadata flags: {0}")]
@@ -375,6 +384,9 @@ pub enum ResultMetadataAndRowsCountParseError {
 /// of result metadata failed.
 #[non_exhaustive]
 #[derive(Error, Debug, Clone)]
+// Check triggers because all variants end with "ParseError".
+// TODO(2.0): Remove the "ParseError" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum ResultMetadataParseError {
     /// Failed to parse metadata flags.
     #[error("Malformed metadata flags: {0}")]
@@ -422,6 +434,9 @@ pub struct ColumnSpecParseError {
 /// of a column specification.
 #[non_exhaustive]
 #[derive(Error, Debug, Clone)]
+// Check triggers because all variants end with "ParseError".
+// TODO(2.0): Remove the "ParseError" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum ColumnSpecParseErrorKind {
     #[error("Invalid table spec: {0}")]
     TableSpecParseError(#[from] TableSpecParseError),

scylla-cql/src/frame/mod.rs

@@ -31,8 +31,11 @@ pub mod flag {
     pub const WARNING: u8 = 0x08;
 }
 
-// All of the Authenticators supported by Scylla
+/// All of the Authenticators supported by Scylla
 #[derive(Debug, PartialEq, Eq, Clone)]
+// Check triggers because all variants end with "Authenticator".
+// TODO(2.0): Remove the "Authenticator" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum Authenticator {
     AllowAllAuthenticator,
     PasswordAuthenticator,

scylla-cql/src/frame/response/event.rs

@@ -6,6 +6,9 @@ use crate::frame::types;
 use std::net::SocketAddr;
 
 #[derive(Debug)]
+// Check triggers because all variants end with "Change".
+// TODO(2.0): Remove the "Change" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum Event {
     TopologyChange(TopologyChangeEvent),
     StatusChange(StatusChangeEvent),
@@ -25,6 +28,9 @@ pub enum StatusChangeEvent {
 }
 
 #[derive(Debug)]
+// Check triggers because all variants end with "Change".
+// TODO(2.0): Remove the "Change" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum SchemaChangeEvent {
     KeyspaceChange {
         change_type: SchemaChangeType,

scylla-cql/src/frame/server_event_type.rs

@@ -3,6 +3,9 @@ use std::str::FromStr;
 
 use super::frame_errors::CqlEventParseError;
 
+// Check triggers because all variants end with "Change".
+// TODO(2.0): Remove the "Change" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum EventType {
     TopologyChange,
     StatusChange,

scylla/src/cluster/metadata.rs

@@ -359,6 +359,9 @@ impl std::str::FromStr for ColumnKind {
 
 #[derive(Clone, Debug, PartialEq, Eq)]
 #[non_exhaustive]
+// Check triggers because all variants end with "Strategy".
+// TODO(2.0): Remove the "Strategy" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum Strategy {
     SimpleStrategy {
         replication_factor: usize,

scylla/src/errors.rs

@@ -116,6 +116,9 @@ pub enum PrepareError {
 /// An error that occurred during construction of [`QueryPager`][crate::client::pager::QueryPager].
 #[derive(Error, Debug, Clone)]
 #[non_exhaustive]
+// Check triggers because all variants end with "Error".
+// TODO(2.0): Remove the "Error" postfix from variants.
+#[expect(clippy::enum_variant_names)]
 pub enum PagerExecutionError {
     /// Failed to prepare the statement.
     #[error("Failed to prepare the statement to be used by the pager: {0}")]

scylla/src/routing/partitioner.rs

@@ -21,6 +21,11 @@ use crate::statement::prepared::TokenCalculationError;
 pub enum PartitionerName {
     #[default]
     Murmur3,
+    // Check triggers, because according to guidelines acronyms should be counted
+    // as one word and written in UpperCamelCase. In this case the variant should
+    // be Cdc.
+    // TODO(2.0): Rename variant to Cdc.
+    #[expect(clippy::upper_case_acronyms)]
     CDC,
 }
 
@@ -53,6 +58,12 @@ impl Partitioner for PartitionerName {
 #[non_exhaustive]
 pub enum PartitionerHasherAny {
     Murmur3(Murmur3PartitionerHasher),
+    // Check triggers, because according to guidelines acronyms should be counted
+    // as one word and written in UpperCamelCase. In this case the variant should
+    // be Cdc.
+    // TODO(2.0): Rename variant to Cdc.
+    // TODO(2.0): Rename CDCPartitionerHasher to CdcPartitionerHasher
+    #[expect(clippy::upper_case_acronyms)]
     CDC(CDCPartitionerHasher),
 }