Merge pull request #898 from oeb25/misplaced-chrono-feature

scylla-cql: Use `#[cfg(feature = "time")]` for `time` related `impl SerializeCql`'s

Author: piodul

.github/workflows/rust.yml

@@ -34,6 +34,12 @@ jobs:
       run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features ""
     - name: Cargo check with all serialization features
       run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "full-serialization"
+    - name: Cargo check with secret feature
+      run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "secret"
+    - name: Cargo check with chrono feature
+      run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "chrono"
+    - name: Cargo check with time feature
+      run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "time"
     - name: Build scylla-cql
       run: cargo build --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml" --features "full-serialization"
     - name: Build

scylla-cql/src/types/serialize/value.rs

@@ -172,21 +172,21 @@ impl SerializeCql for NaiveTime {
         <CqlTime as SerializeCql>::serialize(&cql_time, typ, writer)?
     });
 }
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 impl SerializeCql for time::Date {
     impl_serialize_via_writer!(|me, typ, writer| {
         exact_type_check!(typ, Date);
         <CqlDate as SerializeCql>::serialize(&(*me).into(), typ, writer)?
     });
 }
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 impl SerializeCql for time::OffsetDateTime {
     impl_serialize_via_writer!(|me, typ, writer| {
         exact_type_check!(typ, Timestamp);
         <CqlTimestamp as SerializeCql>::serialize(&(*me).into(), typ, writer)?
     });
 }
-#[cfg(feature = "chrono")]
+#[cfg(feature = "time")]
 impl SerializeCql for time::Time {
     impl_serialize_via_writer!(|me, typ, writer| {
         exact_type_check!(typ, Time);