Skip to content

Commit 3a0ca2e

Browse files
committed
keepalive: trace in case of success
cpp-rust-driver tests sometimes depend upon logs emitted by the driver. HeartbeatTests are on of them. Tests look for a following log: `logger_.add_critera("Heartbeat completed on host " + ccm_->get_ip_prefix());`. Before this commit, rust-driver was not emitting any logs in case of keepalive request success. I think it's not a bad idea to add a trace log here, considering that keepalive intervals are rather long (default is 30s). Obviously, the logger criteria will need to be adjusted in `cpp-rust-driver` tests as well.
1 parent f9a3635 commit 3a0ca2e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

scylla/src/transport/connection.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1839,6 +1839,11 @@ impl Connection {
18391839
);
18401840
return Err(err);
18411841
}
1842+
1843+
trace!(
1844+
"Keepalive request successful on connection to node {}",
1845+
node_address
1846+
);
18421847
}
18431848
} else {
18441849
// No keepalives are to be sent.

0 commit comments

Comments
 (0)