Skip to content

Commit 4f0a05e

Browse files
committed
CI: Remove verbose output
It has not been useful even once in my experience, but it makes output unreadable. If we ever need it, we can restore it. I wanted to make it conditional. The way to do this is to enable the env variable that controls verbosity if the CI is run in debug mode. Github Actions allows checking it with "runner.debug" variable. Obvious idea is to put something like `CARGO_TERM_VERBOSE: "${{ runner.debug == '1' && 'true' || 'false' }}"` in the workflow's "env" section. This does not work, because `runner` context is not available in workflow env, and not even in job env. This means we would have to put this env in every single step that may need verbose, which is absurd. Another example of GitHub being a truly terrible tool.
1 parent 37ac106 commit 4f0a05e

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

.github/workflows/authenticate_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
run: docker compose -f test/cluster/docker-compose-passauth.yml up -d
3030

3131
- name: Run tests
32-
run: SCYLLA_URI=172.43.0.2 RUST_LOG=trace cargo test --verbose authenticate_superuser -- custom_authentication --ignored
32+
run: SCYLLA_URI=172.43.0.2 RUST_LOG=trace cargo test authenticate_superuser -- custom_authentication --ignored
3333

3434
- name: Stop the cluster
3535
if: ${{ always() }}

.github/workflows/book.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
- name: Install mdbook
3434
run: cargo install mdbook --no-default-features
3535
- name: Build the project
36-
run: cargo build --verbose --examples
36+
run: cargo build --examples
3737
- name: Build the book
3838
run: mdbook build docs
3939
- name: Run book tests

.github/workflows/cassandra.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ jobs:
2727
- name: Update rust toolchain
2828
run: rustup update
2929
- name: Build the project
30-
run: cargo build --verbose --tests --features "full-serialization"
30+
run: cargo build --tests --features "full-serialization"
3131
- name: Run tests on cassandra
3232
run: |
33-
CDC='disabled' RUSTFLAGS="--cfg cassandra_tests" RUST_LOG=trace SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose --features "full-serialization" -- --skip test_views_in_schema_info --skip test_large_batch_statements
33+
CDC='disabled' RUSTFLAGS="--cfg cassandra_tests" RUST_LOG=trace SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --features "full-serialization" -- --skip test_views_in_schema_info --skip test_large_batch_statements
3434
- name: Stop the cluster
3535
if: ${{ always() }}
3636
run: docker compose -f test/cluster/cassandra/docker-compose.yml stop

.github/workflows/rust.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ jobs:
3030
- name: Print clippy version
3131
run: cargo clippy --version
3232
- name: Format check
33-
run: cargo fmt --verbose --all -- --check
33+
run: cargo fmt --all -- --check
3434
- name: Clippy check
35-
run: cargo clippy --verbose --all-targets
35+
run: cargo clippy --all-targets
3636
- name: Clippy check with all features
37-
run: cargo clippy --verbose --all-targets --all-features
37+
run: cargo clippy --all-targets --all-features
3838
- name: Cargo check with cpp_rust_unstable cfg
39-
run: RUSTFLAGS="--cfg cpp_rust_unstable" cargo clippy --verbose --all-targets --all-features
39+
run: RUSTFLAGS="--cfg cpp_rust_unstable" cargo clippy --all-targets --all-features
4040

4141
# Features checks.
4242
# No features.
@@ -71,9 +71,9 @@ jobs:
7171
# (openssl-x, rustls-x) is checked in tls.yml.
7272

7373
- name: Build scylla-cql
74-
run: cargo build --verbose --all-targets --manifest-path "scylla-cql/Cargo.toml" --features "full-serialization"
74+
run: cargo build --all-targets --manifest-path "scylla-cql/Cargo.toml" --features "full-serialization"
7575
- name: Build
76-
run: cargo build --verbose --all-targets --features "full-serialization"
76+
run: cargo build --all-targets --features "full-serialization"
7777
tests:
7878
runs-on: ubuntu-latest
7979
timeout-minutes: 60
@@ -90,7 +90,7 @@ jobs:
9090
- name: Run tests
9191
run: |
9292
cargo clean
93-
RUST_LOG=trace SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --verbose --features "full-serialization"
93+
RUST_LOG=trace SCYLLA_URI=172.42.0.2:9042 SCYLLA_URI2=172.42.0.3:9042 SCYLLA_URI3=172.42.0.4:9042 cargo test --features "full-serialization"
9494
- name: Stop the cluster
9595
if: ${{ always() }}
9696
run: docker compose -f test/cluster/docker-compose.yml stop
@@ -114,11 +114,11 @@ jobs:
114114
- name: Use MSRV Cargo.lock
115115
run: mv Cargo.lock.msrv Cargo.lock
116116
- name: MSRV cargo check with features
117-
run: cargo check --verbose --all-targets --all-features --locked
117+
run: cargo check --all-targets --all-features --locked
118118
- name: MSRV cargo check without features
119-
run: cargo check --verbose --all-targets --locked --manifest-path "scylla/Cargo.toml"
119+
run: cargo check --all-targets --locked --manifest-path "scylla/Cargo.toml"
120120
- name: MSRV cargo check scylla-cql
121-
run: cargo check --verbose --all-targets --locked --manifest-path "scylla-cql/Cargo.toml"
121+
run: cargo check --all-targets --locked --manifest-path "scylla-cql/Cargo.toml"
122122

123123
# Tests that docstrings generate docs without warnings
124124
cargo_docs:

.github/workflows/serverless.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: Update rust toolchain
3232
run: rustup update
3333
- name: Check
34-
run: cargo check --verbose
34+
run: cargo check
3535
# Cloud-related feature sets.
3636
- name: Cargo check with unstable-cloud and openssl-x features
3737
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features "unstable-cloud" --features "openssl-010"
@@ -45,7 +45,7 @@ jobs:
4545
- name: Run cloud-rustls example
4646
run: cargo run --example cloud-rustls -- $HOME/.ccm/serverless/config_data.yaml
4747
- name: Run cloud tests
48-
run: CLOUD_CONFIG_PATH=$HOME/.ccm/serverless/config_data.yaml RUSTFLAGS="--cfg scylla_cloud_tests" RUST_LOG=trace cargo test --verbose
48+
run: CLOUD_CONFIG_PATH=$HOME/.ccm/serverless/config_data.yaml RUSTFLAGS="--cfg scylla_cloud_tests" RUST_LOG=trace cargo test
4949

5050
- name: Remove serverless cluster
5151
run: ccm remove serverless

.github/workflows/tls.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
run: rustup update
2727

2828
- name: Check
29-
run: cargo check --verbose --features "openssl-010" --features "rustls-023"
29+
run: cargo check --features "openssl-010" --features "rustls-023"
3030
working-directory: ${{env.working-directory}}
3131

3232
- name: Start the cluster

0 commit comments

Comments
 (0)