make_error_replace_rust_name: Allow specifying privacy

Some of the function defined using this macro are only used inside the
crate, or not used at all, and thus don't need to be public.

Author: Lorak-mmk

scylla-cql/src/deserialize/mod.rs

@@ -296,10 +296,11 @@ impl DeserializationError {
 // - ONLY in proper type_check()/deserialize() implementation,
 // - BEFORE an error is cloned (because otherwise the Arc::get_mut fails).
 macro_rules! make_error_replace_rust_name {
-    ($fn_name: ident, $outer_err: ty, $inner_err: ty) => {
+    ($privacy: vis, $fn_name: ident, $outer_err: ty, $inner_err: ty) => {
         // Not part of the public API; used in derive macros.
         #[doc(hidden)]
-        pub fn $fn_name<RustT>(mut err: $outer_err) -> $outer_err {
+        #[allow(clippy::needless_pub_self)]
+        $privacy fn $fn_name<RustT>(mut err: $outer_err) -> $outer_err {
             // Safety: the assumed usage of this function guarantees that the Arc has not yet been cloned.
             let arc_mut = std::sync::Arc::get_mut(&mut err.0).unwrap();
 

scylla-cql/src/deserialize/row.rs

@@ -125,12 +125,14 @@ impl<'frame, 'metadata> DeserializeRow<'frame, 'metadata> for ColumnIterator<'fr
 }
 
 make_error_replace_rust_name!(
+    pub(self),
     _typck_error_replace_rust_name,
     TypeCheckError,
     BuiltinTypeCheckError
 );
 
 make_error_replace_rust_name!(
+    pub,
     deser_error_replace_rust_name,
     DeserializationError,
     BuiltinDeserializationError

scylla-cql/src/deserialize/value.rs

@@ -675,12 +675,14 @@ where
 // collections
 
 make_error_replace_rust_name!(
+    pub(crate),
     typck_error_replace_rust_name,
     TypeCheckError,
     BuiltinTypeCheckError
 );
 
 make_error_replace_rust_name!(
+    pub,
     deser_error_replace_rust_name,
     DeserializationError,
     BuiltinDeserializationError