Skip to content

Commit 7de2bf6

Browse files
committed
scylla-macros: Add dev-dep on scylla and scylla-cql
This will allow us to run doctests after moving doc comments of derive macros into this crate. Interestingly, this change causes a warning about unnecessary unwrap_or_else in the scylla crate. I did not investigate why this happens (or perhaps more interestingly: why it didn't happen before).
1 parent 700fe6d commit 7de2bf6

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

Cargo.lock.msrv

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scylla-macros/Cargo.toml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,12 @@ proc-macro2 = "1.0"
2121
[lints.rust]
2222
unnameable_types = "warn"
2323
unreachable_pub = "warn"
24+
25+
# When bumping major version of scylla / scylla-cql, those dependencies
26+
# also need to be updated. Fortunately Cargo will yell very loudly if that
27+
# is not done.
28+
# When bumping minor versions of scylla / scylla-cql nothing bad will happen
29+
# if we forget to update versions here.
30+
[dev-dependencies]
31+
scylla = { version = "0.15.0", path = "../scylla"}
32+
scylla-cql = { version = "0.4.0", path = "../scylla-cql"}

scylla/src/client/session.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -802,6 +802,7 @@ impl Session {
802802
#[cfg(not(feature = "unstable-cloud"))]
803803
let cloud_known_nodes: Option<Vec<InternalKnownNode>> = None;
804804

805+
#[allow(clippy::unnecessary_literal_unwrap)]
805806
let known_nodes = cloud_known_nodes
806807
.unwrap_or_else(|| known_nodes.into_iter().map(|node| node.into()).collect());
807808

0 commit comments

Comments
 (0)