Skip to content

Commit 7f7f2d0

Browse files
committed
session_test: Don't use ClusterData::get_datacenters_info
This method does some things that are unnecessary here: - For each DC it allocates a vector with it's nodes - It calculates rack count (which requires .unique() call which allocates) For the purpose of this test - and I'm pretty sure most of possible usages of get_datacenters_info - it is enough to get DC names from replica locator.
1 parent d7ba747 commit 7f7f2d0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

scylla/src/transport/session_test.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ use crate::routing::Token;
88
use crate::statement::Consistency;
99
use crate::test_utils::{scylla_supports_tablets, setup_tracing};
1010
use crate::tracing::TracingInfo;
11-
use crate::transport::cluster::Datacenter;
1211
use crate::transport::errors::{BadKeyspaceName, BadQuery, DbError, QueryError};
1312
use crate::transport::partitioner::{
1413
calculate_token_for_partition_key, Murmur3Partitioner, Partitioner, PartitionerName,
@@ -1874,10 +1873,11 @@ async fn test_turning_off_schema_fetching() {
18741873
let cluster_data = &session.get_cluster_data();
18751874
let keyspace = &cluster_data.get_keyspace_info()[&ks];
18761875

1877-
let datacenters: HashMap<String, Datacenter> = cluster_data.get_datacenters_info();
1878-
let datacenter_repfactors: HashMap<String, usize> = datacenters
1879-
.into_keys()
1880-
.map(|dc_name| (dc_name, 1))
1876+
let datacenter_repfactors: HashMap<String, usize> = cluster_data
1877+
.replica_locator()
1878+
.datacenter_names()
1879+
.iter()
1880+
.map(|dc_name| (dc_name.to_owned(), 1))
18811881
.collect();
18821882

18831883
assert_eq!(

0 commit comments

Comments
 (0)