treewide: adjust docstrings and variable names to statement terminology

Author: muzarski

scylla/src/client/execution_profile.rs

@@ -1,4 +1,4 @@
-//! `ExecutionProfile` is a grouping of configurable options regarding query execution.
+//! `ExecutionProfile` is a grouping of configurable options regarding CQL statement execution.
 //!
 //! Profiles can be created to represent different workloads, which thanks to them
 //! can be run conveniently on a single session.
@@ -38,7 +38,7 @@
 //! ```
 //!
 //! ### Example
-//! To create an `ExecutionProfile` and attach it to a `Query`:
+//! To create an [`ExecutionProfile`] and attach it to a [`Statement`](crate::statement::Statement):
 //! ```
 //! # extern crate scylla;
 //! # use std::error::Error;
@@ -82,7 +82,7 @@
 //! let profile = base_profile.to_builder()
 //!     .consistency(Consistency::All)
 //!     .build();
-//
+//!
 //! # Ok(())
 //! # }
 //! ```
@@ -259,16 +259,16 @@ impl ExecutionProfileBuilder {
         self
     }
 
-    /// Specify a default consistency to be used for queries.
+    /// Specify a default consistency to be used for statement executions.
     /// It's possible to override it by explicitly setting a consistency on the chosen query.
     pub fn consistency(mut self, consistency: Consistency) -> Self {
         self.consistency = Some(consistency);
         self
     }
 
-    /// Specify a default serial consistency to be used for queries.
+    /// Specify a default serial consistency to be used for statement executions.
     /// It's possible to override it by explicitly setting a serial consistency
-    /// on the chosen query.
+    /// on the chosen statement.
     pub fn serial_consistency(mut self, serial_consistency: Option<SerialConsistency>) -> Self {
         self.serial_consistency = Some(serial_consistency);
         self
@@ -297,7 +297,7 @@ impl ExecutionProfileBuilder {
         self
     }
 
-    /// Sets the [`RetryPolicy`] to use by default on queries.
+    /// Sets the [`RetryPolicy`] to use by default on statements.
     /// The default is [DefaultRetryPolicy](crate::policies::retry::DefaultRetryPolicy).
     /// It is possible to implement a custom retry policy by implementing the trait [`RetryPolicy`].
     ///
@@ -390,11 +390,11 @@ impl Default for ExecutionProfileBuilder {
     }
 }
 
-/// A profile that groups configurable options regarding query execution.
+/// A profile that groups configurable options regarding statement execution.
 ///
 /// Execution profile is immutable as such, but the driver implements double indirection of form:
-/// query/Session -> ExecutionProfileHandle -> ExecutionProfile
-/// which enables on-fly changing the actual profile associated with all entities (query/Session)
+/// statement/Session -> [`ExecutionProfileHandle`] -> [`ExecutionProfile`]
+/// which enables on-fly changing the actual profile associated with all entities (statements/Session)
 /// by the same handle.
 #[derive(Debug, Clone)]
 pub struct ExecutionProfile(pub(crate) Arc<ExecutionProfileInner>);
@@ -493,7 +493,7 @@ impl ExecutionProfile {
 
 /// A handle that points to an ExecutionProfile.
 ///
-/// Its goal is to enable remapping all associated entities (query/Session)
+/// Its goal is to enable remapping all associated entities (statement/Session)
 /// to another execution profile at once.
 /// Note: Cloned handles initially point to the same Arc'ed execution profile.
 /// However, as the mapping has yet another level of indirection - through
@@ -521,7 +521,7 @@ impl ExecutionProfileHandle {
     }
 
     /// Makes the handle point to a new execution profile.
-    /// All entities (queries/Session) holding this handle will reflect the change.
+    /// All entities (statements/Session) holding this handle will reflect the change.
     pub fn map_to_another_profile(&mut self, profile: ExecutionProfile) {
         self.0 .0.store(profile.0)
     }

scylla/src/client/pager.rs

@@ -661,47 +661,47 @@ impl QueryPager {
     }
 
     pub(crate) async fn new_for_query(
-        query: Statement,
+        statement: Statement,
         execution_profile: Arc<ExecutionProfileInner>,
         cluster_state: Arc<ClusterState>,
         metrics: Arc<Metrics>,
     ) -> Result<Self, NextPageError> {
         let (sender, receiver) = mpsc::channel::<Result<ReceivedPage, NextPageError>>(1);
 
-        let consistency = query
+        let consistency = statement
             .config
             .consistency
             .unwrap_or(execution_profile.consistency);
-        let serial_consistency = query
+        let serial_consistency = statement
             .config
             .serial_consistency
             .unwrap_or(execution_profile.serial_consistency);
 
-        let page_size = query.get_validated_page_size();
+        let page_size = statement.get_validated_page_size();
 
         let routing_info = RoutingInfo {
             consistency,
             serial_consistency,
             ..Default::default()
         };
 
-        let retry_session = query
+        let retry_session = statement
             .get_retry_policy()
             .map(|rp| &**rp)
             .unwrap_or(&*execution_profile.retry_policy)
             .new_session();
 
         let parent_span = tracing::Span::current();
         let worker_task = async move {
-            let query_ref = &query;
+            let statement_ref = &statement;
 
             let page_query = |connection: Arc<Connection>,
                               consistency: Consistency,
                               paging_state: PagingState| {
                 async move {
                     connection
                         .query_raw_with_consistency(
-                            query_ref,
+                            statement_ref,
                             consistency,
                             serial_consistency,
                             Some(page_size),
@@ -711,7 +711,7 @@ impl QueryPager {
                 }
             };
 
-            let query_ref = &query;
+            let query_ref = &statement;
 
             let span_creator = move || {
                 let span = RequestSpan::new_query(&query_ref.contents);
@@ -723,13 +723,13 @@ impl QueryPager {
                 sender: sender.into(),
                 page_query,
                 statement_info: routing_info,
-                query_is_idempotent: query.config.is_idempotent,
+                query_is_idempotent: statement.config.is_idempotent,
                 query_consistency: consistency,
                 retry_session,
                 execution_profile,
                 metrics,
                 paging_state: PagingState::start(),
-                history_listener: query.config.history_listener.clone(),
+                history_listener: statement.config.history_listener.clone(),
                 current_request_id: None,
                 current_attempt_id: None,
                 parent_span,