Remove redundant clippy attributes

Some checks stopped triggering since we introduced those lines, for one
reason or another. There is no need to keep them.

Author: Lorak-mmk

scylla-cql/src/deserialize/result.rs

@@ -256,9 +256,6 @@ mod tests {
         fn lend_next(&mut self) -> Option<Result<Self::Item<'_>, DeserializationError>>;
     }
 
-    // Disable the lint, if there is more than one lifetime included.
-    // Can be removed once https://github.com/rust-lang/rust-clippy/issues/12495 is fixed.
-    #[allow(clippy::needless_lifetimes)]
     impl<'frame, 'metadata> LendingIterator for RawRowIterator<'frame, 'metadata> {
         type Item<'borrow>
             = ColumnIterator<'borrow, 'borrow>

scylla-cql/src/deserialize/row_tests.rs

@@ -84,12 +84,10 @@ fn test_deserialization_as_column_iterator() {
 // Do not remove. It's not used in tests but we keep it here to check that
 // we properly ignore warnings about unused variables, unnecessary `mut`s
 // etc. that usually pop up when generating code for empty structs.
-#[allow(unused)]
 #[derive(DeserializeRow)]
 #[scylla(crate = crate)]
 struct TestUdtWithNoFieldsUnordered {}
 
-#[allow(unused)]
 #[derive(DeserializeRow)]
 #[scylla(crate = crate, flavor = "enforce_order")]
 struct TestUdtWithNoFieldsOrdered {}

scylla-cql/src/deserialize/value_tests.rs

@@ -1200,12 +1200,10 @@ impl UdtSerializer {
 // Do not remove. It's not used in tests but we keep it here to check that
 // we properly ignore warnings about unused variables, unnecessary `mut`s
 // etc. that usually pop up when generating code for empty structs.
-#[allow(unused)]
 #[derive(scylla_macros::DeserializeValue)]
 #[scylla(crate = crate)]
 struct TestUdtWithNoFieldsUnordered {}
 
-#[allow(unused)]
 #[derive(scylla_macros::DeserializeValue)]
 #[scylla(crate = crate, flavor = "enforce_order")]
 struct TestUdtWithNoFieldsOrdered {}

scylla-cql/src/frame/request/batch.rs

@@ -226,9 +226,6 @@ impl BatchStatement<'_> {
     }
 }
 
-// Disable the lint, if there is more than one lifetime included.
-// Can be removed once https://github.com/rust-lang/rust-clippy/issues/12495 is fixed.
-#[allow(clippy::needless_lifetimes)]
 impl<'s, 'b> From<&'s BatchStatement<'b>> for BatchStatement<'s> {
     fn from(value: &'s BatchStatement) -> Self {
         match value {

scylla-cql/src/serialize/batch_tests.rs

@@ -320,7 +320,6 @@ fn tuple_batch_values() {
 }
 
 #[test]
-#[allow(clippy::needless_borrow)]
 fn ref_batch_values() {
     let batch_values: &[&[i8]] = &[&[1, 2], &[2, 3, 4, 5], &[6]];
     let cols = &[
@@ -338,7 +337,6 @@ fn ref_batch_values() {
 }
 
 #[test]
-#[allow(clippy::needless_borrow)]
 fn check_ref_tuple() {
     fn assert_has_batch_values<BV: BatchValues>(bv: BV, cols: &[&[ColumnSpec]]) {
         let mut iter = make_batch_value_iter(&bv);

scylla-cql/src/serialize/row_tests.rs

@@ -94,7 +94,6 @@ fn test_dyn_serialize_row() {
 #[test]
 fn test_tuple_errors() {
     // Unit
-    #[allow(clippy::let_unit_value)] // The let binding below is intentional
     let v = ();
     let spec = [col("a", ColumnType::Native(NativeType::Text))];
     let err = do_serialize_err(v, &spec);
@@ -224,7 +223,6 @@ fn test_map_errors() {
 // Do not remove. It's not used in tests but we keep it here to check that
 // we properly ignore warnings about unused variables, unnecessary `mut`s
 // etc. that usually pop up when generating code for empty structs.
-#[allow(unused)]
 #[derive(SerializeRow)]
 #[scylla(crate = crate)]
 struct TestRowWithNoColumns {}

scylla-macros/src/deserialize/row.rs

@@ -322,7 +322,6 @@ impl DeserializeAssumeOrderGenerator<'_> {
 
         parse_quote! {
             fn deserialize(
-                #[allow(unused_mut)]
                 mut row: #macro_internal::ColumnIterator<#frame_lifetime, #metadata_lifetime>,
             ) -> ::std::result::Result<Self, #macro_internal::DeserializationError> {
                 ::std::result::Result::Ok(Self {
@@ -576,8 +575,7 @@ impl DeserializeUnorderedGenerator<'_> {
 
         parse_quote! {
             fn deserialize(
-                #[allow(unused_mut)]
-                mut row: #macro_internal::ColumnIterator<#frame_lifetime, #metadata_lifetime>,
+                row: #macro_internal::ColumnIterator<#frame_lifetime, #metadata_lifetime>,
             ) -> ::std::result::Result<Self, #macro_internal::DeserializationError> {
 
                 // Generate fields that will serve as temporary storage

scylla-macros/src/deserialize/value.rs

@@ -536,8 +536,7 @@ impl DeserializeAssumeOrderGenerator<'_> {
         let field_idents = fields.iter().map(|f| f.ident.as_ref().unwrap());
         let field_finalizers = fields.iter().map(|f| self.generate_finalize_field(f));
 
-        #[allow(unused_mut)]
-        let mut iterator_type: syn::Type =
+        let iterator_type: syn::Type =
             parse_quote!(#macro_internal::UdtIterator<#frame_lifetime, #metadata_lifetime>);
 
         parse_quote! {

scylla/src/cloud/config.rs

@@ -168,9 +168,7 @@ pub enum CloudTlsProvider {
 #[derive(Debug)]
 pub(crate) struct AuthInfo {
     tls: TlsInfo,
-    #[allow(unused)]
     username: Option<String>,
-    #[allow(unused)]
     password: Option<String>,
 }
 
@@ -282,11 +280,9 @@ impl AuthInfo {
 pub(crate) struct Datacenter {
     ca_cert: TlsCert,
     server: String,
-    #[allow(unused)]
     tls_server_name: Option<String>,
     node_domain: String,
     insecure_skip_tls_verify: bool,
-    #[allow(unused)]
     proxy_url: Option<String>,
 }
 

scylla/src/cluster/metadata.rs

@@ -359,7 +359,6 @@ impl std::str::FromStr for ColumnKind {
 
 #[derive(Clone, Debug, PartialEq, Eq)]
 #[non_exhaustive]
-#[allow(clippy::enum_variant_names)]
 pub enum Strategy {
     SimpleStrategy {
         replication_factor: usize,