Skip to content

Commit f3b10ef

Browse files
committed
iter: narrow return error type of SingleConnectionPagerWorker::do_work
1 parent aa2a3e2 commit f3b10ef

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

scylla/src/client/pager.rs

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@ use crate::cluster::{ClusterState, NodeRef};
2929
#[allow(deprecated)]
3030
use crate::cql_to_rust::{FromRow, FromRowError};
3131
use crate::deserialize::DeserializeOwnedRow;
32-
use crate::errors::{ProtocolError, RequestError};
33-
use crate::errors::{QueryError, RequestAttemptError};
32+
use crate::errors::{QueryError, RequestAttemptError, RequestError};
3433
use crate::frame::response::result;
3534
use crate::network::Connection;
3635
use crate::observability::driver_tracing::RequestSpan;
@@ -490,21 +489,17 @@ where
490489
match self.do_work().await {
491490
Ok(proof) => proof,
492491
Err(err) => {
493-
let (proof, _) = self.sender.send(Err(err)).await;
492+
let (proof, _) = self.sender.send(Err(err.into_query_error())).await;
494493
proof
495494
}
496495
}
497496
}
498497

499-
async fn do_work(&mut self) -> Result<PageSendAttemptedProof, QueryError> {
498+
async fn do_work(&mut self) -> Result<PageSendAttemptedProof, RequestAttemptError> {
500499
let mut paging_state = PagingState::start();
501500
loop {
502-
let result = (self.fetcher)(paging_state)
503-
.await
504-
.map_err(RequestAttemptError::into_query_error)?;
505-
let response = result
506-
.into_non_error_query_response()
507-
.map_err(RequestAttemptError::into_query_error)?;
501+
let result = (self.fetcher)(paging_state).await?;
502+
let response = result.into_non_error_query_response()?;
508503
match response.response {
509504
NonErrorResponse::Result(result::Result::Rows((rows, paging_state_response))) => {
510505
let (proof, send_result) = self
@@ -539,10 +534,9 @@ where
539534
return Ok(proof);
540535
}
541536
_ => {
542-
return Err(ProtocolError::UnexpectedResponse(
537+
return Err(RequestAttemptError::UnexpectedResponse(
543538
response.response.to_response_kind(),
544-
)
545-
.into());
539+
));
546540
}
547541
}
548542
}

0 commit comments

Comments
 (0)